feat: add the 'oldest sort method to sort by creation day, ascending#224
Merged
gcv merged 1 commit intonex3:masterfrom Feb 3, 2026
Merged
feat: add the 'oldest sort method to sort by creation day, ascending#224gcv merged 1 commit intonex3:masterfrom
gcv merged 1 commit intonex3:masterfrom
Conversation
This adds the `'oldest` keyword to sort by creation day, ascending (oldest first). This also adds a test for this behavior and the needed documentation.
Collaborator
|
My instinct is that Meanwhile, I’ll merge this in. Thank you for contributing to Perspective. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the
'oldestkeyword to sort by creation day, ascending (oldest first). This also adds a test for this behavior and the needed documentation.There is a slightly odd behavior, as documented in the test. Because persp-find-some defaults to returning the first in the list, and with
'oldestthat's the oldest, when a persp is killed it can end up going back tomaininstead of the previously created persp. Not sure how to handle this since technically it fits with the expected behavior of the other sort methods. I could make it so that persp-find-some will either recognize 'oldest and instead call the name/sort function with either created or accessed. Accessed makes most sense to me, but that's a design decision that I think is beyond the PR maybe, or at least beyond me since it'd be a change in how things function.