Closed
Conversation
Collaborator
|
I never paid attention to this file before, but now that I’ve looked at it, I think it’s supposed to be the way it is: it’s supposed to create an alias from the old name to the new name for Git tracking purposes. I looked it up here: https://lukasmestan.com/using-mailmap-in-git-repository/ If I understand it correctly, applying your patch would cause the name change to be ignored in old Git history. Which doesn’t seem like the right thing at all. |
Author
|
My bad, disregard this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found the commit title "Fix my name" interesting and the fact that it was 10 years old, so I looked at it and noticed that
.mailmaphad incorrect names and it bothered me too much not to create a PR.Sorry if this is weird.