Feature: Add Insecure SSL support for electrum server#3
Merged
Conversation
…ent on BDK-FFI that exposes validate_domain parameter in the electrum client contstructor
Owner
Author
|
I expect the build and analyze GitHub action to fail unless BDK is updated or the Packaged is updated to point to a forked version. |
Owner
Author
|
I decided to fork bdk-ffi and bdk-swift. I added one single commit (newtonick/bdk-ffi@94099a7) off of v2.3.1. My intention is to go back to proper BDK v3 once my PR is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependency on bitcoindevkit/bdk-ffi#975 unless I want to fork bdk-ffi in the short term.
Testing Notes:
Switching bdk-swift between local and remote
Hellbender depends on bdk-swift (BitcoinDevKit) via SPM. During normal development it uses the remote release. When testing local bdk-ffi changes (e.g. the
v2.3.0-ssl-patchbranch), switch to the local copy.Switch to local bdk-swift
export SOURCE=~"/Source"$SOURCE/bdk-swift/Package.swift, change the binary target to use a local path:bdk-swiftpackage dependency, then File → Add Package Dependencies → Add Local... and select$SOURCE/bdk-swift.Switch back to remote bdk-swift
$SOURCE/bdk-swift/Package.swift, restore the remote binary target:bdk-swiftpackage dependency.https://github.com/bitcoindevkit/bdk-swift→ Exact Version2.3.1→ AddBitcoinDevKitto the hellbender target.