-
Notifications
You must be signed in to change notification settings - Fork 0
Prod infra #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prod infra #33
Conversation
entropic489
commented
Jan 2, 2026
- adds managed databases for prod
- refactors EcsStack to accomodate prod or dev infra
- removes account and vpc ids
- adds github action for building to prod ECR on tag builds
|
Hi there - please send me an email @ the address in my git profile, have something to disclose regarding your LibreChat deployment |
ignore this person |
|
Okay, @entropic489 I wanted to mention that your development deployed version of LibreChat allows anyone to register and use the AI. Whether or not that is a concern is up to you guys 😅 |
|
okay, thanks. I've disabled cognito self-signup |
|
|
||
| if (isProd) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A higher-level question, but does it makes sense (in the long run) to have our stack be identical between dev and prod, just for ease of understanding? (Since right now there's a bunch of differing logic between dev and prod, and anyone coming along later to modify it might be confused as to why we're going down different paths for each environment.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could, but it'd be more expensive. The big difference right now is that dev runs its databases in sidecar containers (cheaper, but self-managed dbs), vs prod which uses managed databases (more expensive, better backup/recovery)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be worth bringing up with NJ how much they care about infra cost vs. ease of maintenance. I'm curious how much more expensive the managed DBs are - if it's just a few bucks/month then it's probably worth doing the simpler route.
AnJuHyppolite
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a clarifying question. Nice work, Josh!
* checkin * checkin * checkin * checkin * still need apigateway * obscure acct ids * vpc id * obscure vpc ids * no vpc id env var * revert * run on tags, fail if not prod * run on tags, fail if not prod * adds tag check * adds tag check * add newline --------- Co-authored-by: Josh Fink <josh.fink@innovation.nj.gov>