Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successfully implemented Taylor & Francis source parser for ACE with the following components:
Implementation Summary
1. Configuration File (
ace/sources/TaylorAndFrancis.json)2. Source Parser (
TaylorAndFrancisSourceinace/sources.py)Key Features:
tandf.tfviewerdataJavaScript object containing table HTMLTechnical Implementation:
_extract_tables_from_javascript(): Finds and extracts JavaScript table data using string slicing (more robust than regex)_parse_table_data(): Parses JSON data and extracts individual table HTML_extract_tables_from_csv(): Fallback CSV download methodextract_doi()andextract_pmid(): Metadata extraction with multiple fallback methods3. Test Suite (
test_taylor_and_francis_sourceinace/tests/test_ace.py)4. Additional Fixes
ace/utils.pyby specifying "lxml" parserTest Results
✅ Test passed successfully - extracts 2 tables from Taylor & Francis HTML with correct metadata and activations
The parser is now ready to handle Taylor & Francis publications and can be extended to support the CSV download fallback method for cases where JavaScript extraction fails.