-
-
Notifications
You must be signed in to change notification settings - Fork 13
add gnome shell 49 support #147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Also, this morning the extension was working only partially on GNOME 49, so I started replacing the get_child_at_index() calls manually. I included a small helper function that maps them to get_children()[n]. This makes the extension work properly again on GNOME 49 while keeping compatibility with previous versions (≥ 40). metadata.json was also updated to add "49" in shell-version. Tested after these changes and the extension behaves correctly. |
ryzendew
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it works as needed nice work!
|
When will this be released on gnome extension site |
|
I also test this in another distros with gnome 49 but if there's another issue just let me know... |
|
Can I update open bar |
|
I wanted to add this works on my system too. |
|
Working on fedora! |
|
Clone the fork, compile and move to the extension folder... while they implement the solve...
|
|
Did you mean to write to me? I am saying it works on my system with your changes, I don't need to do anything else. I said, "I want to add this works on my system too", not "I want to add this on my system too". :)
|
|
It's still not released yet on gnome extension site? |
|
how do i getthis to work on my system |
He updated the main version but I'm not Sure if is a merge from this, you can clone my fork and install or clone the original repository and make this... |
|
Hello All, First of all Thanks a lot @xscriptorcode for the PR, truely appreciate it! The PR has a lot of formatting diffs (likely due to auto-formatter extensions) which dilutes the main concern. Also it tackles the issue a bit differently though it is quite neat. I have now updated the code in the main branch based on change-guide from Gnome. Thus, I will have to close the PR here. It would be great if you can try out the updated code from 'main' branch and let me know how it goes. Thanks again! |
This PR adds compatibility with GNOME Shell 49.
Updated metadata.json to include "49" in shell-version.
Verified extension loads correctly on GNOME 49 (EndeavourOS / Arch Linux).
Thanks for maintaining this great extension!
Closes #146
Notes: