Added some UPS device files for Ippon and Talegent

[penghong123]

I tested both NUT2.7.4 and NUT2.8.3.64, and they can both read the UPS status normally
and control the UPS devices properly, such as shutting down.
Make a contribution.

See also:

• Ippon's Na+ series UPS is supported by blazer_ser. nut#2923
• Talegent UPS is supported by blazer_ser. nut#2924
• Increased the UPS equipment and corresponding descriptions from Ippon and Talegent manufacturers. nut#2952

[jimklimov]

@penghong123 : somehow XML markup crawled into the data dumps (many files, not sure if all of them or not), e.g.:

input.voltage.nominal: 230
output.voltage: 230.4<Question ID="2" Shortcut="chapter 1" Order="" ElementType="chapter" >
<LongCaption><Question ID="1" Shortcut="Q1" Order="" ElementType="question" QuestionType="closed" MinResponse="1" MaxResponse="1" Anonymity="1" AllowDK="1" Translated="0" >
<LongCaption></LongCaption>
<Modalities>undefined<Routings>
</Routings>
</Question></LongCaption>
</Question>
ups.beeper.status: enabled
ups.delay.shutdown: 30

Can you please revise the PR and add a commit to fix this?

• remove the XML parts of the text
• revise if there were any lines reported by upsc that did not get copy-pasted here

[jimklimov]

@penghong123 : I've revised those files to remove the XML markup; it is still questionable if there were some NUT data points missed in place where buggy information was.

The manual revisiting also seems to have been a waste of time - it seems that all ~30 files are identical, and (all but one?) are not real data dumps of each referenced device model individually. So instead of editing 30 files individually I could have edited one and copied to 30 places much faster :(

But in practice this duplication is also almost useless: there may be nuances of each device model exposed in their data points (different capacity etc.) We need real data to compare devices and drivers over time, find some patterns when hunting for bugs, etc.

• Can you please revise this PR again, to either upload real data dumps from real devices into corresponding file names, or to remove files that do not contain information actually collected from a device of that model?

And we still need you to check if any data points got lost with the broken markup of initial posting?

[penghong123]

@penghong123 : I've revised those files to remove the XML markup; it is still questionable if there were some NUT data points missed in place where buggy information was.：我已经修改了这些文件以删除 XML 标记;在有错误的信息所在的地方是否遗漏了一些 NUT 数据点仍然值得怀疑。

The manual revisiting also seems to have been a waste of time - it seems that all ~30 files are identical, and (all but one?) are not real data dumps of each referenced device model individually. So instead of editing 30 files individually I could have edited one and copied to 30 places much faster :(手动重新访问似乎也是浪费时间 - 似乎所有 ~30 个文件都是相同的，并且（除了一个之外）都不是每个引用设备模型的真实数据转储。因此，与其单独编辑 30 个文件，不如编辑 1 个文件并复制到 30 个位置，速度要快得多:(

But in practice this duplication is also almost useless: there may be nuances of each device model exposed in their data points (different capacity etc.) We need real data to compare devices and drivers over time, find some patterns when hunting for bugs, etc.但在实践中，这种重复也几乎毫无用处：每个设备模型的数据点中可能会暴露出细微差别（不同的容量等）。我们需要真实的数据来比较设备和驱动程序随时间的变化，在寻找错误时找到一些模式，等等。

• Can you please revise this PR again, to either upload real data dumps from real devices into corresponding file names, or to remove files that do not contain information actually collected from a device of that model?您能否再次修改此 PR，将真实设备中的真实数据转储上传到相应的文件名中，或者删除不包含从该型号的设备实际收集的信息的文件？

And we still need you to check if any data points got lost with the broken markup of initial posting?我们仍然需要您检查是否有任何数据点因初始发布的损坏标记而丢失？

Sorry, I've been too busy lately to pay attention to the message. Then I delete the other files and only keep one file, because those machines are borrowed by me and have been returned.

[jimklimov]

I see... and just in case, you don't have any real test results for other UPS models on your computer, which you would have just forgot to add to git?

Which actual model is posted here? It is hard to see from

ups.mfr: 222222222222222
ups.model: 2222222222

[penghong123]

I see... and just in case, you don't have any real test results for other UPS models on your computer, which you would have just forgot to add to git?

Which actual model is posted here? It is hard to see from

ups.mfr: 222222222222222
ups.model: 2222222222

At that time, I only focused on whether the NUT could be adapted to these machines, and forgot to record the data. When I tested it, I found that their results were all not very different, so I didn't pay attention to the differences between them.

Here's the data from the Vitality 1KS machine.

ups.mfr: 222222222222222
ups.model: 2222222222

Do I need to delete other files and resubmit?

[jimklimov]

If you can, yes, please. Thank you!

[penghong123]

If you can, yes, please. Thank you!

Sorry, I'm not very familiar with the Git tool. I've made multiple submissions. I'm not sure if the submission as shown in the picture is feasible. The commit shown in the image has deleted the dev file that has no test data.

I've been struggling with the DCO issue in the following picture for a while and haven't been able to solve it. I have no idea how to deal with it.

[jimklimov]

Thanks, at least the resulting state looks good now.

The DCO check is optional for now, detailed here : https://github.com/networkupstools/nut/wiki/Code-contributions,-PRs,-PGP-and-DCO (in short, a legalese-encouraged sign-off that a human who had the intellectual-property right to the contribution does contribute it).

[penghong123]

Thanks, at least the resulting state looks good now.

The DCO check is optional for now, detailed here : https://github.com/networkupstools/nut/wiki/Code-contributions,-PRs,-PGP-and-DCO (in short, a legalese-encouraged sign-off that a human who had the intellectual-property right to the contribution does contribute it).

Now, is there anything else I need to do?

[jimklimov]

Now, is there anything else I need to do?

No, thanks - all good now; merged :)