Fixes [0..numComponents-1] when numComponents is 0. This would eval…
#1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uate `numComponents-1` to 18446744073709551615, because numComponents is of type Foreign.C.Types.CSize, an unsigned integer, and rolls over to the its maxBound.
Author
|
Looks like something wrong is happening while building libpostal. |
Owner
|
Yes, I'll take a look at it this week. Thanks for the PR.
Pedro Furlanetto <notifications@github.com> ezt írta (időpont: 2019. júl.
26., P 16:34):
… Looks like something wrong is happening while building libpostal.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1?email_source=notifications&email_token=AAFJXG3RD42PS2VSUS4ORJ3QBMDPNA5CNFSM4IHDT562YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD24ZGIQ#issuecomment-515478306>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAFJXG63PWVOVEZU27OOBWDQBMDPNANCNFSM4IHDT56Q>
.
|
Author
|
I guess the failure is due to https://github.com/netom/haskell-postal/blob/master/script/ci-build.sh#L20. I am going to give a try on building this branch over the weekend. |
Owner
|
I'm gonna try to build it against v1.0.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…uate
numComponents-1to 18446744073709551615, because numComponents is of type Foreign.C.Types.CSize, an unsigned integer, and rolls over to the its maxBound.