NETOBSERV-2417: Display Loki labels in bold in filters dropdown #1133
Conversation
|
@OlivierCazade: This pull request references NETOBSERV-2417 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
OlivierCazade
force-pushed
the
highlight-labels
branch
from
b3c5246 to
3f2ca4b
Compare
jotak
added
the
ok-to-test
|
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=884e9bf make set-plugin-image |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1133 +/- ##
==========================================
- Coverage 52.95% 47.27% -5.69%
==========================================
Files 209 40 -169
Lines 10950 2845 -8105
Branches 1391 0 -1391
==========================================
- Hits 5799 1345 -4454
+ Misses 4602 1327 -3275
+ Partials 549 173 -376
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
| key={index} | ||
| > | ||
| {f.name} | ||
| {isLokiLabel(f, config) ? <strong>{f.name}</strong> : f.name} |
There was a problem hiding this comment.
Do we need a tooltip somewhere to explain what bold text means here ?
There was a problem hiding this comment.
What kind of tooltip do you have in mind ? Do you have an example ?
There was a problem hiding this comment.
☝️ directly on the dropdown could work but be carefull as we already have one on the inputgroup
We also have some mentions in other places we could improve:
https://github.com/search?q=repo%3Anetobserv%2Fnetwork-observability-console-plugin+%22indexed+fields%22&type=code
filters (which use indexed fields) -> filters (in bold which use indexed fields)
Amoghrd
removed
the
ok-to-test
|
/ok-to-test |
openshift-ci
bot
added
the
ok-to-test
|
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=f508365 make set-plugin-image |
|
@OlivierCazade I dont see any filters in bold🤔 The loki filters here in this dropdown should be bold right? |
|
@Amoghrd if you first load the main console plugin you probably need to clean cache and reload. 
|
|
Yeah, I think had not refreshed when I took previously.
Light mode: Dark mode: |
|
+1 for a short explanation text somewhere, e.g. something like: @Amoghrd I'm not sure to understand your comment on the dark mode; I haven't tested myself, but based on your screenshot, bold text appears on dark mode as well? |
|
My comment was that in dark mode bold is not apparent as in light mode. So an explanation is must. Italics might help to stand out in dark mode too is what I was suggesting😅 |
OlivierCazade
force-pushed
the
highlight-labels
branch
from
3f2ca4b to
1fe3b65
Compare
|
New changes are detected. LGTM label has been removed. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
github-actions
bot
removed
the
ok-to-test
OlivierCazade
force-pushed
the
highlight-labels
branch
from
1fe3b65 to
5cb78d8
Compare
|
I had to refactor most of the PR to handle new filter structure. Tooltip is also added now : 
|
| )} | ||
| <Tooltip | ||
| content={ | ||
| <div>Select a field name to filter on. Use indexed fields in bold to improve your query performances.</div> |
There was a problem hiding this comment.
| <div>Select a field name to filter on. Use indexed fields in bold to improve your query performances.</div> | |
| <div>{t('Select a field name to filter on. Use indexed fields in bold to improve your query performances.')}</div> |
- Add lokiLabels to frontend config - Populate lokiLabels from Loki config - Add isLokiLabel helper function - Update FiltersDropdown to highlight Loki labels
OlivierCazade
force-pushed
the
highlight-labels
branch
from
5cb78d8 to
8feff10
Compare
6 participants
Description
Display Loki labels in bold in filters dropdown
Dependencies
n/a
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.