Feature: Make window title work on all platforms #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netniV
changed the title
netniV
added a commit
that referenced
this pull request
Dec 25, 2025
* Merge doc changes (#67) * Create FUNDING.yml * Update README.md * Bump dawidd6/action-download-artifact from 3 to 6 in /.github/workflows (#50) Bumps [dawidd6/action-download-artifact](https://github.com/dawidd6/action-download-artifact) from 3 to 6. - [Release notes](https://github.com/dawidd6/action-download-artifact/releases) - [Commits](dawidd6/action-download-artifact@v3...v6) --- updated-dependencies: - dependency-name: dawidd6/action-download-artifact dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update ci.yaml to v3 * Update ci.yaml to v4 * Update example_community_patch_settings.toml (#51) set the default to false in the example file and also added a warning to the faulty Features --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Bloody142 <alfred.herlitz@yahoo.de> * Update documentation for 0.6.1 release (#68) * Mac config path migration help (#69) * updated .vscode settings for xmake + clangd setup * improved mac specific part of install.md * added automatic config migration for mac users * fix community_patch_runtime.vars typo * Apply suggestions from code review Co-authored-by: netniV <netniv@hotmail.com> --------- Co-authored-by: netniV <netniv@hotmail.com> * Fix default values (#70) * Stop queuing when you reach the end of the queue! * Make armada's work with right click * change to static build to avoid vc runtime dependencies (#71) Co-authored-by: netniV <netniv@hotmail.com> * Add settings button for mac users (#72) * add hotkey for Scrap Yard (#75) * add hostkey for Scrap Yard * Update example_community_patch_settings.toml Co-authored-by: netniV <netniv@hotmail.com> --------- Co-authored-by: netniV <netniv@hotmail.com> * add wine install docs and general revision and updates. (#76) * add wine install docs and general revision and updates. * Update INSTALL.md Co-authored-by: netniV <netniv@hotmail.com> * Update INSTALL.md Co-authored-by: netniV <netniv@hotmail.com> * Update INSTALL.md Co-authored-by: netniV <netniv@hotmail.com> * Update INSTALL.md Co-authored-by: netniV <netniv@hotmail.com> * Update INSTALL.md Co-authored-by: netniV <netniv@hotmail.com> * Update INSTALL.md Co-authored-by: netniV <netniv@hotmail.com> * Update INSTALL.md Co-authored-by: netniV <netniv@hotmail.com> * typo * update mac steps * INSTALL.md * mac specific * Clarify instructions for accessing the hidden ~/Library folder on MacOS in INSTALL.md * Improve clarity and readability of Wine/Linux installation instructions in INSTALL.md * Fix formatting in Wine installation instructions in INSTALL.md --------- Co-authored-by: netniV <netniv@hotmail.com> * Release prep * Update example configuration for release * Add simdutf to MacOS build requirements * Another try for the mac users * Another try for the mac users * Set version to Alpha 8 * Fix issue with Hrojost, allow dev-only patch disabling and debug/trace options * Fix up some CI issues * Fix up some CI cache issues * Some more CI changes * Update README.md * Chat hotkey fixes (#77) * Remove ActionView key handing in chat - not needed interferes with emoji input * Adjust indexes due to Cadet Chat addition * Update mods/src/prime/ChatManager.h Co-authored-by: netniV <netniv@hotmail.com> --------- Co-authored-by: netniV <netniv@hotmail.com> * Fix FleetBarViewController * Unity updates (#83) * Update protobuf to version 32.1 * Update libil2cpp to 6000.0.52f1 * Update GameAssembly.lib * Update .proto files to M82.1 * Switch back to xmake's protobuf-cpp and remove the custom local package * Update sync module with new capabilities and performance improvements (#78) * Initial rework of the sync module [skip ci] - Implement sync for buffs, inventory, jobs, and slots - Process game data asynchronously - Introduce per-target config options * Refactor [sync] config - Introduce `SyncConfig` class to centralize sync option management - Improve handling of per-target sync configurations * Update sync functionality - Replace `libcurl` with `cpr` for HTTP requests - Improve logging with enhanced context in sync functions - Add thread-safe session and target management for sync - Centralize data processing by introducing `SyncConfig::Type` enums and updated queuing system # Conflicts: # mods/xmake.lua * Update sync module and logging enhancements - Add new `SyncConfig::Type::EmeraldChain` for expanded sync options - Add alliance name/tags to player data when uploading battle logs - Rename `std::lock_guard lock` to `std::lock_guard lk` for consistency and to avoid confusion - Introduce `sync_log_trace()` for more granular logging - Refactor caching for player and alliance profiles with improved expiration handling * Misc improvements and bug fixes for sync - Add `sync_resolver_cache_ttl` parameter for configurable TTL - Improve context in error logging across sync operations - Refine handling of player/alliance data, slot states, and combat log parsing - Fix minor inconsistencies in JSON processing and state handling * Reformat code * Remove support for syncing to files * Update sync module with improvements, logging refinements, and error-handling enhancements - Introduce RAII guard for Windows COM apartments - Update Unity and libcurl version strings - Refactor SSL and proxy configuration for improved clarity - Enhance error logging with additional exception handling - Refactor sync functions for better maintainability and performance * Experiment with semaphores * Simplify sync response handling * Consolidate Mission types, enhance buff and job handling, and refine sync error logging * Fix sync not propagating Emerald Chain level drops during session * Fix active missions sync * Reduce verbosity of log output * Handle slot updates/removals - Introduced `RealtimeDataPayload` class for RTC-related data handling. - Implemented `process_entity_slots_rtc` to support real-time synchronization of entity slots. * Update `parse_timestamp` to use `std::chrono::system_clock` instead of `std::chrono::utc_clock` * Switch to strptime due to lack of support for std::chrono::from_stream, guard release of semaphore, add timeouts * Fix issues related to missing hooks (#86) * Unforce the Cursor, and other bug fixes (#84) * Make cursor optional * Change cursor method, and some minor fixes * Fix the windows-only code * Updated CHANGELOG * Update workflows for GitHub CI * Cleanup depends and fix the macOS build (#87) * Version string substitution for MacOS build (#81) * Initial plan * Implement version substitution in macOS launcher Info.plist Co-authored-by: ttimbul <7075787+ttimbul@users.noreply.github.com> * Complete version substitution implementation with template-based approach Co-authored-by: ttimbul <7075787+ttimbul@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: ttimbul <7075787+ttimbul@users.noreply.github.com> * Fix issues with Mac CI * Attempt to fix MacOS CI again * Another go! * Oh, try again! * Remove the extra end then. * Fix the bsae name * Prevent switching to disabled chats (#88) * Switch to per-target workers for sync (#89) * Refactor `RealtimeDataPayload` property accessors for improved naming consistency. * Rename `authentication_service` to `prime_app` for clarity * Updated hooks to include `serverRegion` parameter in `PrimeApp_InitPrimeServer` and `GameServer_Initialise` * Improve `parse_timestamp` error handling * Add missing `break` statements to sync processing blocks * Add exception handling for `submit_async` task spawning * Refactor sync queue handling - Use libcurl for better URL manipulation. - Add per-target worker threads for asynchronous request handling. - Introduce `verify_ssl` to sync configuration for enhanced flexibility. - Simplify mutex usage, remove response handling threads, and improve logging. * Add `level_percentage` to ship sync data * Add back per-request identifiers - Replace `target_name` with `identifier` for better granularity in logging and error tracking. - Update request queue to store paired identifier and payload. * Introduce first-sync flag - Add first-sync detection using `std::once_flag` for initial sync requests. * Update default value for `verify_ssl` to be consistent with the config parser * Refactor sync logic and replace `std::jthread` with `std::thread` - Remove `std::stop_token` in favor of `std::atomic<bool>` for thread cancellation. - Refactor `first-sync` handling using `std::atomic_bool` for better concurrency. - Improve error handling, logging, and header management for initial sync requests. - Adjust `parse_timestamp` to return `std::optional` for better failure handling. * enable automatic re-sign from macOS launcher (#91) * add changes to patch entitlements at startup * add a mac helper script for build/test/debug cycles from cmdline, to save having to build the dmg all the time * CI improvements (#90) * Add universal macOS build to CI workflow * Simplify xmake caching setup in CI workflow * Add Info.plist copying step to macOS universal build in CI * Refine xmake caching keys to exclude platform-specific files in CI workflow * Rename "Community Patch" references to "Community Mod" across workflows and macOS launcher configurations. * Simplify xmake cache key configuration by removing redundant `runner.os` references in CI workflow * Don't skip code signing on error * Fix typo in job name * Update macOS runner and remove redundant Homebrew setup in CI workflow * Add `build-cache-path` configuration to CI workflow * Downgrade macOS runner version * Update `INSTALL.md` [skip ci] * Stop downloading battle log data when no sync targets are configured (#93) * Update release workflow * Update macOS patcher to skip code signature files. Force re-sign after (#95) patching and remove some dead code in signature path. * Update logos and backgrounds (#97) * Update file picker message to tell users that they don't need to pick anything, just continue (#96) * Update to use DefaultConfig.h and add some extra keys * Fix use_out_of_dock_power (#99) * Update hook for `BuffService::IsBuffConditionMet` * Remove non-package caches * Update macOS build configs to explicitly target macOS 13.5 as the minimum (#98) * Update defaults and example settings * Fix: change how buffs are handled * Feature: Make window title work on all platforms (#100) * fix: Make window title work properly * Lets try round two... * Lets include the filemanager, eh? * Lets answer the static vs inline debate... * Lets set the return value then... * Lets set the return value then... * Disable sliders for Mac users (#101) * Add settings shortcut (Shift+S) (#102) * Update version number * It's christmas, lets release it --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Bloody142 <alfred.herlitz@yahoo.de> Co-authored-by: b2k5 <b2k5@b2k5.de> Co-authored-by: gmn42 <78309818+gmn42@users.noreply.github.com> Co-authored-by: pwrskr <arendorpower@proton.me> Co-authored-by: lightbull <lightbull.stfc@gmail.com> Co-authored-by: Ehren Bendler <a5ehren@gmail.com> Co-authored-by: ttimbul <ttimbul@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: ttimbul <7075787+ttimbul@users.noreply.github.com>
ttimbul
added a commit
to ttimbul/stfc-mod
that referenced
this pull request
Jan 5, 2026
* Version string substitution for MacOS build (netniV#81) * Initial plan * Implement version substitution in macOS launcher Info.plist Co-authored-by: ttimbul <7075787+ttimbul@users.noreply.github.com> * Complete version substitution implementation with template-based approach Co-authored-by: ttimbul <7075787+ttimbul@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: ttimbul <7075787+ttimbul@users.noreply.github.com> * Update README.md * Merge 1.0.0 (netniV#104) * Merge doc changes (netniV#67) * Create FUNDING.yml * Update README.md * Bump dawidd6/action-download-artifact from 3 to 6 in /.github/workflows (netniV#50) Bumps [dawidd6/action-download-artifact](https://github.com/dawidd6/action-download-artifact) from 3 to 6. - [Release notes](https://github.com/dawidd6/action-download-artifact/releases) - [Commits](dawidd6/action-download-artifact@v3...v6) --- updated-dependencies: - dependency-name: dawidd6/action-download-artifact dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update ci.yaml to v3 * Update ci.yaml to v4 * Update example_community_patch_settings.toml (netniV#51) set the default to false in the example file and also added a warning to the faulty Features --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Bloody142 <alfred.herlitz@yahoo.de> * Update documentation for 0.6.1 release (netniV#68) * Mac config path migration help (netniV#69) * updated .vscode settings for xmake + clangd setup * improved mac specific part of install.md * added automatic config migration for mac users * fix community_patch_runtime.vars typo * Apply suggestions from code review Co-authored-by: netniV <netniv@hotmail.com> --------- Co-authored-by: netniV <netniv@hotmail.com> * Fix default values (netniV#70) * Stop queuing when you reach the end of the queue! * Make armada's work with right click * change to static build to avoid vc runtime dependencies (netniV#71) Co-authored-by: netniV <netniv@hotmail.com> * Add settings button for mac users (netniV#72) * add hotkey for Scrap Yard (netniV#75) * add hostkey for Scrap Yard * Update example_community_patch_settings.toml Co-authored-by: netniV <netniv@hotmail.com> --------- Co-authored-by: netniV <netniv@hotmail.com> * add wine install docs and general revision and updates. (netniV#76) * add wine install docs and general revision and updates. * Update INSTALL.md Co-authored-by: netniV <netniv@hotmail.com> * Update INSTALL.md Co-authored-by: netniV <netniv@hotmail.com> * Update INSTALL.md Co-authored-by: netniV <netniv@hotmail.com> * Update INSTALL.md Co-authored-by: netniV <netniv@hotmail.com> * Update INSTALL.md Co-authored-by: netniV <netniv@hotmail.com> * Update INSTALL.md Co-authored-by: netniV <netniv@hotmail.com> * Update INSTALL.md Co-authored-by: netniV <netniv@hotmail.com> * typo * update mac steps * INSTALL.md * mac specific * Clarify instructions for accessing the hidden ~/Library folder on MacOS in INSTALL.md * Improve clarity and readability of Wine/Linux installation instructions in INSTALL.md * Fix formatting in Wine installation instructions in INSTALL.md --------- Co-authored-by: netniV <netniv@hotmail.com> * Release prep * Update example configuration for release * Add simdutf to MacOS build requirements * Another try for the mac users * Another try for the mac users * Set version to Alpha 8 * Fix issue with Hrojost, allow dev-only patch disabling and debug/trace options * Fix up some CI issues * Fix up some CI cache issues * Some more CI changes * Update README.md * Chat hotkey fixes (netniV#77) * Remove ActionView key handing in chat - not needed interferes with emoji input * Adjust indexes due to Cadet Chat addition * Update mods/src/prime/ChatManager.h Co-authored-by: netniV <netniv@hotmail.com> --------- Co-authored-by: netniV <netniv@hotmail.com> * Fix FleetBarViewController * Unity updates (netniV#83) * Update protobuf to version 32.1 * Update libil2cpp to 6000.0.52f1 * Update GameAssembly.lib * Update .proto files to M82.1 * Switch back to xmake's protobuf-cpp and remove the custom local package * Update sync module with new capabilities and performance improvements (netniV#78) * Initial rework of the sync module [skip ci] - Implement sync for buffs, inventory, jobs, and slots - Process game data asynchronously - Introduce per-target config options * Refactor [sync] config - Introduce `SyncConfig` class to centralize sync option management - Improve handling of per-target sync configurations * Update sync functionality - Replace `libcurl` with `cpr` for HTTP requests - Improve logging with enhanced context in sync functions - Add thread-safe session and target management for sync - Centralize data processing by introducing `SyncConfig::Type` enums and updated queuing system # Conflicts: # mods/xmake.lua * Update sync module and logging enhancements - Add new `SyncConfig::Type::EmeraldChain` for expanded sync options - Add alliance name/tags to player data when uploading battle logs - Rename `std::lock_guard lock` to `std::lock_guard lk` for consistency and to avoid confusion - Introduce `sync_log_trace()` for more granular logging - Refactor caching for player and alliance profiles with improved expiration handling * Misc improvements and bug fixes for sync - Add `sync_resolver_cache_ttl` parameter for configurable TTL - Improve context in error logging across sync operations - Refine handling of player/alliance data, slot states, and combat log parsing - Fix minor inconsistencies in JSON processing and state handling * Reformat code * Remove support for syncing to files * Update sync module with improvements, logging refinements, and error-handling enhancements - Introduce RAII guard for Windows COM apartments - Update Unity and libcurl version strings - Refactor SSL and proxy configuration for improved clarity - Enhance error logging with additional exception handling - Refactor sync functions for better maintainability and performance * Experiment with semaphores * Simplify sync response handling * Consolidate Mission types, enhance buff and job handling, and refine sync error logging * Fix sync not propagating Emerald Chain level drops during session * Fix active missions sync * Reduce verbosity of log output * Handle slot updates/removals - Introduced `RealtimeDataPayload` class for RTC-related data handling. - Implemented `process_entity_slots_rtc` to support real-time synchronization of entity slots. * Update `parse_timestamp` to use `std::chrono::system_clock` instead of `std::chrono::utc_clock` * Switch to strptime due to lack of support for std::chrono::from_stream, guard release of semaphore, add timeouts * Fix issues related to missing hooks (netniV#86) * Unforce the Cursor, and other bug fixes (netniV#84) * Make cursor optional * Change cursor method, and some minor fixes * Fix the windows-only code * Updated CHANGELOG * Update workflows for GitHub CI * Cleanup depends and fix the macOS build (netniV#87) * Version string substitution for MacOS build (netniV#81) * Initial plan * Implement version substitution in macOS launcher Info.plist Co-authored-by: ttimbul <7075787+ttimbul@users.noreply.github.com> * Complete version substitution implementation with template-based approach Co-authored-by: ttimbul <7075787+ttimbul@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: ttimbul <7075787+ttimbul@users.noreply.github.com> * Fix issues with Mac CI * Attempt to fix MacOS CI again * Another go! * Oh, try again! * Remove the extra end then. * Fix the bsae name * Prevent switching to disabled chats (netniV#88) * Switch to per-target workers for sync (netniV#89) * Refactor `RealtimeDataPayload` property accessors for improved naming consistency. * Rename `authentication_service` to `prime_app` for clarity * Updated hooks to include `serverRegion` parameter in `PrimeApp_InitPrimeServer` and `GameServer_Initialise` * Improve `parse_timestamp` error handling * Add missing `break` statements to sync processing blocks * Add exception handling for `submit_async` task spawning * Refactor sync queue handling - Use libcurl for better URL manipulation. - Add per-target worker threads for asynchronous request handling. - Introduce `verify_ssl` to sync configuration for enhanced flexibility. - Simplify mutex usage, remove response handling threads, and improve logging. * Add `level_percentage` to ship sync data * Add back per-request identifiers - Replace `target_name` with `identifier` for better granularity in logging and error tracking. - Update request queue to store paired identifier and payload. * Introduce first-sync flag - Add first-sync detection using `std::once_flag` for initial sync requests. * Update default value for `verify_ssl` to be consistent with the config parser * Refactor sync logic and replace `std::jthread` with `std::thread` - Remove `std::stop_token` in favor of `std::atomic<bool>` for thread cancellation. - Refactor `first-sync` handling using `std::atomic_bool` for better concurrency. - Improve error handling, logging, and header management for initial sync requests. - Adjust `parse_timestamp` to return `std::optional` for better failure handling. * enable automatic re-sign from macOS launcher (netniV#91) * add changes to patch entitlements at startup * add a mac helper script for build/test/debug cycles from cmdline, to save having to build the dmg all the time * CI improvements (netniV#90) * Add universal macOS build to CI workflow * Simplify xmake caching setup in CI workflow * Add Info.plist copying step to macOS universal build in CI * Refine xmake caching keys to exclude platform-specific files in CI workflow * Rename "Community Patch" references to "Community Mod" across workflows and macOS launcher configurations. * Simplify xmake cache key configuration by removing redundant `runner.os` references in CI workflow * Don't skip code signing on error * Fix typo in job name * Update macOS runner and remove redundant Homebrew setup in CI workflow * Add `build-cache-path` configuration to CI workflow * Downgrade macOS runner version * Update `INSTALL.md` [skip ci] * Stop downloading battle log data when no sync targets are configured (netniV#93) * Update release workflow * Update macOS patcher to skip code signature files. Force re-sign after (netniV#95) patching and remove some dead code in signature path. * Update logos and backgrounds (netniV#97) * Update file picker message to tell users that they don't need to pick anything, just continue (netniV#96) * Update to use DefaultConfig.h and add some extra keys * Fix use_out_of_dock_power (netniV#99) * Update hook for `BuffService::IsBuffConditionMet` * Remove non-package caches * Update macOS build configs to explicitly target macOS 13.5 as the minimum (netniV#98) * Update defaults and example settings * Fix: change how buffs are handled * Feature: Make window title work on all platforms (netniV#100) * fix: Make window title work properly * Lets try round two... * Lets include the filemanager, eh? * Lets answer the static vs inline debate... * Lets set the return value then... * Lets set the return value then... * Disable sliders for Mac users (netniV#101) * Add settings shortcut (Shift+S) (netniV#102) * Update version number * It's christmas, lets release it --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Bloody142 <alfred.herlitz@yahoo.de> Co-authored-by: b2k5 <b2k5@b2k5.de> Co-authored-by: gmn42 <78309818+gmn42@users.noreply.github.com> Co-authored-by: pwrskr <arendorpower@proton.me> Co-authored-by: lightbull <lightbull.stfc@gmail.com> Co-authored-by: Ehren Bendler <a5ehren@gmail.com> Co-authored-by: ttimbul <ttimbul@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: ttimbul <7075787+ttimbul@users.noreply.github.com> * Update README for v1.0.0 release and compatibility Updated the README to reflect the release of v1.0.0 and its compatibility with the latest STFC clients. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: ttimbul <7075787+ttimbul@users.noreply.github.com> Co-authored-by: netniV <netniv@hotmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Bloody142 <alfred.herlitz@yahoo.de> Co-authored-by: b2k5 <b2k5@b2k5.de> Co-authored-by: gmn42 <78309818+gmn42@users.noreply.github.com> Co-authored-by: pwrskr <arendorpower@proton.me> Co-authored-by: lightbull <lightbull.stfc@gmail.com> Co-authored-by: Ehren Bendler <a5ehren@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.