fix: KeywordBlocker handle null values gracefully #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
I initially thought Kotlin's .toString() method would always safely convert null values into the string "null". However, I've just found out that this safety guarantee disappears when you're dealing with Java Platform Types. In those scenarios, Kotlin defers to Java's rules, which results in a NullPointerException when a null reference is encountered. Thanks a lot for helping!! It does feel like all those issues are indeed solved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that sometimes but infrequently the KeywordBlocker crashes because of a NullPointerException. I don't know what exactly was causing the issue, but this fix seems to work.
I just added some null checks and I had no crashes since.
This should fix: