Support custom SSL certificates for the signal service#2257
Merged
mlsmaycon merged 10 commits intonetbirdio:mainfrom Jul 16, 2024
Merged
Support custom SSL certificates for the signal service#2257mlsmaycon merged 10 commits intonetbirdio:mainfrom
mlsmaycon merged 10 commits intonetbirdio:mainfrom
Conversation
|
|
* initializing the gRPC server is done with the TLS credentials, so maybe it doesn't have to be done for the listener
* it was much simpler
Contributor
Author
|
Whoops. Forced-push to fix authorship issues |
mlsmaycon
approved these changes
Jul 16, 2024
Collaborator
mlsmaycon
left a comment
mlsmaycon
left a comment
There was a problem hiding this comment.
awesome contribution @benniekiss, thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR adds the ability to provide custom SSL certificates to the signal service. Most of the code was adapted from management/cmd/management.go since it already offers the functionality I was looking to implement.
Two flags have been added,
--cert-fileand--cert-key, which accept a string pointing to a file path for the SSL certificate and key. When--letsencrypt-domainis set, these options are ignored.This is my first try at go, so please let me know if anything needs refactored and fixed!
Issue ticket number and link
Along with netbirdio/dashboard#399, closes #2242
Checklist