Disable local users when LocalAuthDisabled = true#546
Conversation
📝 WalkthroughWalkthroughAdded an optional Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@src/modules/users/UsersTable.tsx`:
- Around line 352-355: The external InlineLink in UsersTable (usage of
InlineLink with href "https://docs.netbird.io/..." in UsersTable.tsx) opens in a
new tab via target="_blank" but lacks rel="noopener noreferrer"; update that
InlineLink instance to include rel="noopener noreferrer" to prevent reverse
tabnabbing and ensure safe external linking.
- Around line 340-365: The FullTooltip wrapper is forcing "ml-auto" which
overrides caller alignment; update the conditional render where
localAuthDisabled is handled (the FullTooltip around {button} in UsersTable.tsx)
to use the caller-provided className instead of hardcoded "ml-auto" — e.g.,
remove the literal ml-auto and pass through a prop/className variable so
consumers control alignment; ensure FullTooltip still receives any needed
default classes but does not unconditionally apply ml-auto.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.