Permit filtering unassigned peers

[EdouardVanbelle]

Please find a very small improvement in peers list:

• permit a serial lookup on peers table
• display the peer's serial number (to avoid. new column I added it in the OS section:

• display of the serial number in the peer section

• capability to filter peers that belong to the "All" group only, this is useful to track non assigned peers
  

[heisbrot]

Hey @EdouardVanbelle,

thanks for this PR! I like the idea of filtering by unassigned peers.
However, we should look into having it in another position to keep the filters clean.

I was thinking of either in the groups filter or having a dropdown with (All Peers, Online Peers, Offline Peers, Unassigned Peers) instead of the current buttons. What do you think?

[EdouardVanbelle]

Hello @heisbrot interesting ! You are right the current case is a bit confusing

I am also thinking that All, Online, Offline filters complements the group filtering (you can mix both)

To complete your suggestion the dropdown with a selector before the separator and a checkbox on unassigned peers:

 ( ) All Peers
 ( ) Online Peers
 ( ) Offline Peers
 -----
 [ ] unassigned peers

I find more coherent your first suggestion, meaning keeping All, Online, Offline buttons and complete the dropdown group like this:

  [ ] groupA 
  [ ] groupB
  [ ] groupC
  -----
  [ ] unassigned peers

Right now I have this incoherent case: (I must implement an exclusivity)

[EdouardVanbelle]

Hello @heisbrot , I applied your suggestions, which brings:

Changes:

• there is an exclusivity between Unassigned peers and other group selection to keep consistency on this selector
• breaking change: I have also removed the All group in the drop down as all peers are always in this group, this part is arguable, up to you :)
• the Group filter is hidden if the only one group All exists, arguable too :)
• I have added a function overrideTableFilter() in order to keep other columns selection and reduce code redundancy. I guess there is a smarter solution but I don't know this framework
• breaking change: take care that now the Pending Approvals button keeps other column filters (use of overrideTableFilter() function)
• breaking change: I have also swapped buttons' order to keep filters together, and the RowsPerPage later, still up to you :)
• the serial is still present in this merge request

🙏 all my appologies, this is the first time I code in React

[EdouardVanbelle]

Hello @heisbrot I have rebased these commit to resolve a conflict
let me know if you prefer I split this merge request in 2:
1 for serial
1 for the filtering capability on unassigned peers

Regards

[heisbrot]

Hello @heisbrot I have rebased these commit to resolve a conflict let me know if you prefer I split this merge request in 2: 1 for serial 1 for the filtering capability on unassigned peers

Regards

Hey @EdouardVanbelle ,

thank you! Yes a split would be great. We can then directly merge the serial.
The filtering stuff still needs review and some testing from my end. But overall the changes make sense :)

[EdouardVanbelle]

Here it is @heisbrot

you can review first the pull request #444 to validate the serial feature
(I did not squashed your patch)

Then this pull request will contain only the unassigned peers filter

[EdouardVanbelle]

Hello @heisbrot if it helps the review, I split the commit in 2:

• one for the table filter refactor
• the other one for the filtering on unassigned peers

[EdouardVanbelle]

Hello @heisbrot, let me know if still interested in this request and I will resolve the conflict :)
at least the first patch can interest you to refactor the filtering