Merged
Conversation
__declspec(thread) is broken in DLLs loaded via LoadLibrary (PE/COFF loader allocates TLS slots once at process startup). Error at compile time if SNAKEPATH_FLUENT is used in an MSVC DLL build (_WINDLL). Also replace the silent non-thread-safe fallback with a hard error when no TLS mechanism is available. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
netanel-haber
force-pushed
the
fluent-tls-guards
branch
from
8a2701e to
a51867f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#errorif fluent API is compiled into an MSVC DLL (_WINDLL), since__declspec(thread)is broken in DLLs loaded viaLoadLibrary— PE/COFF loader allocates TLS slots once at process startup and cannot grow them for late-loaded DLLs#errorwhen no TLS mechanism is availableTest plan
/LDbuild hits the#error🤖 Generated with Claude Code