Skip to content

feat(PL-4281): enable Otel retry #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Nic Waller (nwaller-nesto) merged 2 commits into from
Dec 8, 2025
Merged

feat(PL-4281): enable Otel retry #95

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f2212a
feat(PL-4281): enable Otel retry
nwaller-nesto Dec 8, 2025
73c9e93
fix: also retry after network-level failures
nwaller-nesto Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 26 additions & 2 deletions internal/observability/tracer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,20 @@ package observability

import (
"context"
"time"

"google.golang.org/grpc"
"google.golang.org/grpc/backoff"

"go.opentelemetry.io/otel"
"go.opentelemetry.io/otel/attribute"
"go.opentelemetry.io/otel/exporters/otlp/otlptrace"
"go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc"
"go.opentelemetry.io/otel/sdk/resource"
"go.opentelemetry.io/otel/sdk/trace"
"go.opentelemetry.io/otel/trace/noop"

semconv "go.opentelemetry.io/otel/semconv/v1.26.0"
oteltrace "go.opentelemetry.io/otel/trace"
"go.opentelemetry.io/otel/trace/noop"
)

type TracerOptions struct {
Expand All @@ -33,6 +36,27 @@ func SetupTracer(opts TracerOptions) (func() error, error) {
otlpClient := otlptracegrpc.NewClient(
otlptracegrpc.WithInsecure(),
otlptracegrpc.WithEndpoint(opts.OTLPEndpoint),
otlptracegrpc.WithTimeout(90*time.Second),
// Configure gRPC connection retry for network-level failures (e.g., "connection refused")
otlptracegrpc.WithDialOption(
grpc.WithConnectParams(grpc.ConnectParams{
Backoff: backoff.Config{
// this delay/multiplier config gives retries at roughly [3, 9, 21, 45, 93] seconds
BaseDelay: 3 * time.Second,
Multiplier: 2.0,
Jitter: 0.2,
MaxDelay: 120 * time.Second,
},
MinConnectTimeout: 5 * time.Second,
}),
),
// Configure application-level retry for retryable errors (e.g., rate limits, temporary server errors)
otlptracegrpc.WithRetry(otlptracegrpc.RetryConfig{
Enabled: true,
InitialInterval: 5 * time.Second,
MaxInterval: 15 * time.Second,
MaxElapsedTime: 90 * time.Second,
}),
)

exporter, err := otlptrace.New(context.Background(), otlpClient)
Expand Down
Loading