fix(setup-universal): call app.use() instead app.get() for express-static#571
Open
ndrsg wants to merge 1 commit intonestjs:masterfrom
Open
fix(setup-universal): call app.use() instead app.get() for express-static#571ndrsg wants to merge 1 commit intonestjs:masterfrom
ndrsg wants to merge 1 commit intonestjs:masterfrom
Conversation
Should be app.use() instead of app.get(). Otherwise there are problems with resolving files in serve-static, because the path gets not stripped with app.get(). https://github.com/expressjs/serve-static
|
Hi! Any news about this PR? I really need this to be in a release. Can I be of any help? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should be app.use() instead of app.get().
Otherwise there are problems with resolving files in serve-static, because the path gets not stripped with app.get().
https://github.com/expressjs/serve-static
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
If a root-static path other than . is used, file resolving in express-static does not behave as expected (404)
Issue Number: N/A
What is the new behavior?
rootStaticPath behaves as expected and resolves relative to viewsPath.
Does this PR introduce a breaking change?
Users that somehow worked-around the file resolving issue need to undo their workaround.
Other information