-
Notifications
You must be signed in to change notification settings - Fork 13
Use version catalog for storing dependencies #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There is one place where version catalog can not be used:
I'm suggesting to instead explicitly declare this dependency in every place where convention plugin is used |
nesk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR! 🙏 Could you add the missing comment?
I think you're right for kotlinx-coroutines-test, we can import it everywhere we need to keep the version inside the catalog. (I can write the commit if you want)
| mavenCentral() | ||
| } | ||
|
|
||
| tasks.named<Wrapper>("wrapper") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a comment here to explain what this code does?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want, you can tell me here what's the point of this code, then let me add the comment and merge the PR :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My apologies about delay, I was moving into new apartments with unfinished renovation so all my free time went into finishing it. And as if that wasn't enough my PC suddenly decided to die. But "Today, we are canceling the apocalypse", I finally finished some important milestone in my "home project" (haha, get it? =D), had some free time to finally fix my PC and write the comment I promised (not this one). Turned out PC was working, just some random HDMI and DP ports ("Display Port" ports, duh) on GPU stopped to work without any particular reason. Maybe because I discussed nvidia's 5000 series GPU's with my friends near my PC. This old GPU's are so jealous, man.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're GPU is clearly jealous, be careful of his toxic behavior 😂
Thank you for the updates!
Moved it! I've been practicing to move things for the last month, so this was pretty easy =D |
7f62974 to
fd680d4
Compare
Minified version of #50 with only
libs.versions.tomlsupport