Skip to content

Conversation

@bejibx
Copy link
Contributor

@bejibx bejibx commented Dec 23, 2024

Minified version of #50 with only libs.versions.toml support

@bejibx
Copy link
Contributor Author

bejibx commented Dec 23, 2024

There is one place where version catalog can not be used:

implementation("org.jetbrains.kotlinx:kotlinx-coroutines-test:1.9.0-RC.2")

I'm suggesting to instead explicitly declare this dependency in every place where convention plugin is used

Copy link
Owner

@nesk nesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR! 🙏 Could you add the missing comment?

I think you're right for kotlinx-coroutines-test, we can import it everywhere we need to keep the version inside the catalog. (I can write the commit if you want)

mavenCentral()
}

tasks.named<Wrapper>("wrapper") {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a comment here to explain what this code does?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want, you can tell me here what's the point of this code, then let me add the comment and merge the PR :)

Copy link
Contributor Author

@bejibx bejibx Jan 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My apologies about delay, I was moving into new apartments with unfinished renovation so all my free time went into finishing it. And as if that wasn't enough my PC suddenly decided to die. But "Today, we are canceling the apocalypse", I finally finished some important milestone in my "home project" (haha, get it? =D), had some free time to finally fix my PC and write the comment I promised (not this one). Turned out PC was working, just some random HDMI and DP ports ("Display Port" ports, duh) on GPU stopped to work without any particular reason. Maybe because I discussed nvidia's 5000 series GPU's with my friends near my PC. This old GPU's are so jealous, man.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're GPU is clearly jealous, be careful of his toxic behavior 😂

Thank you for the updates!

@bejibx
Copy link
Contributor Author

bejibx commented Jan 24, 2025

Thank you for this PR! 🙏 Could you add the missing comment?

I think you're right for kotlinx-coroutines-test, we can import it everywhere we need to keep the version inside the catalog. (I can write the commit if you want)

Moved it! I've been practicing to move things for the last month, so this was pretty easy =D

@bejibx bejibx requested a review from nesk January 26, 2025 20:05
@nesk nesk force-pushed the versions-catalog-support branch from 7f62974 to fd680d4 Compare January 27, 2025 11:33
@nesk nesk merged commit 4ca8f56 into nesk:main Jan 27, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants