Open
Conversation
Fixes ambiguous instances when using shared custom fields. The component and area parameters are now used to get the proper handler.
…to MOODLE_501_STABLE
…into MOODLE_501_STABLE
…into MOODLE_501_STABLE
…into MOODLE_501_STABLE
… MOODLE_501_STABLE
…into MOODLE_501_STABLE
… MOODLE_501_STABLE
…o MOODLE_501_STABLE
packbackbooks/lti-1-3-php-library#169 blocks us from using the new build.1edtech certification tooling. This issue commits that fix as a library customisation/hack for stables, so the suite can be used for annual/bi-annual re-certification.
scoreGiven was being passed as a string (e.g. "8.0"), which caused validation errors in some LMS implementations such as Rustici Engine. According to the LTI specification, scoreGiven must be numeric if present. Co-authored-by: Jake Dallimore <jake@moodle.com>
Fixes a bug where filtering questions by tag the 'NONE' option was not being respected. Automated testing was also added to cover tag filtering conditions in the question bank
…t/moodle-install into MOODLE_501_STABLE
Changes from 8cf9b22 introduced usage of a non-autoloaded class, so we should be resilient and ensure the library in which it resides is always loaded.
When the course format switcher reloads the form, the `$returnto` parameter is of type string: "0", rather of type integer per initial load. In this case the `empty(...)` check is verifying all of empty string, 0 (integer) and "0" (string). Hurrah for PHP type checking.
The Description field within the Subsection edit form has been deprecated since Moodle 5.2 onwards (see MDL-87279). To ensure a smooth transition and avoid data loss for our users, the XD team have prepared a solution to notify them of this upcoming change in stable versions.
Starting in version 3.10, Moodle started to use a different format for the $CFG->branch that has not been fixed here. This is to make sure that we request the correct version of the plugin.
…t/moodle-install into MOODLE_501_STABLE
…into MOODLE_501_STABLE
…into MOODLE_501_STABLE
When a question bank is restored along with a quiz that uses a random question from that bank, the set reference for the random question should now point to the category in the restored bank, rather than original. This uses the question bank context IDs recorded using the method added in MDL-86136 to decide if the set reference's question context is being restored, and update it accordingly. This required adding a new restore step in the restore_root_task, since when a restore is performed asynchronously, the temp IDs table is deleted after the prechecks are performed when the task is queued. Adding this step allows the IDs to be recorded again when the restore runs.
After restoring an activity using shared questions without the question bank they belong to, we may have left over question categories in the target course context. These were being deleted, but any questions they contained weren't. This replaces the bulk delete of question category records with a call to `question_category_delete_safe()` for each category, which will also delete the questions they contain.
…odle into MOODLE_501_STABLE
…into MOODLE_501_STABLE
…into MOODLE_501_STABLE
When viewing an "available but not shown" cm with self-completion set, then clicking the 'Mark as done' button in the activity header.
…nto MOODLE_501_STABLE
…/moodle into MOODLE_501_STABLE
…into MOODLE_501_STABLE
…into MOODLE_501_STABLE
…MOODLE_501_STABLE
…nto MOODLE_501_STABLE
…into MOODLE_501_STABLE
…/moodle into MOODLE_501_STABLE
…into MOODLE_501_STABLE
…into MOODLE_501_STABLE
…/moodle into MOODLE_501_STABLE
…t/moodle-install into MOODLE_501_STABLE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
*** PLEASE DO NOT OPEN PULL REQUESTS VIA GITHUB ***
The moodle.git repository at Github is just a mirror of the official repository. We do not accept pull requests at Github.
See CONTRIBUTING.md guidelines for how to contribute patches for Moodle. Thank you.
--