!!! FEATURE: Replace swiftmailer with symfonymailer#95
Merged
Conversation
dlubitz
force-pushed
the
feature/symfonymailer
branch
from
73f3953 to
b4fc8e0
Compare
kitsunet
approved these changes
Apr 12, 2025
Member
kitsunet
left a comment
kitsunet
left a comment
There was a problem hiding this comment.
Shouldn't this require symfonymailer (not dev) and with at least some version restriction?
Contributor
Author
|
It is optional, as you don't need to use the Email finisher. So I guess it's fine. |
Member
|
It was the same with SwiftMailer. You could use the package without it and use other finishers. |
bwaidelich
approved these changes
Apr 12, 2025
| ); | ||
| if ($validator === null) { | ||
| throw new \RuntimeException('Validator could not get created.', 1744410020); | ||
| } |
Member
There was a problem hiding this comment.
(how) is this change related?
Contributor
Author
There was a problem hiding this comment.
Phpstan was complaining.
nezaniel
requested changes
Apr 12, 2025
dlubitz
commented
Apr 12, 2025
nezaniel
approved these changes
Apr 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the outdated swiftmailer and uses the new symfonymailer package for the email action.