add support for multiple file upload elemnt#82
Open
Conversation
mficzel
requested changes
Oct 6, 2023
Member
mficzel
left a comment
mficzel
left a comment
There was a problem hiding this comment.
Thanks for the pr and sorry it took so long to take a look.
- Can you put the adjustments to the EmailAction into a separate PR or explain why they are needed here
- Can you add a test to \Neos\Fusion\Form\Tests\Functional\FormTest as there are tests for the generation of the trusted properties. That will prevent regressions in future and allow to understand better what is currently wrong and beeing changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #81