Skip to content

BUGFIX: validated step will not be validated again#66

Open
MarcoPNS wants to merge 1 commit intoneos:mainfrom
MarcoPNS:bugfix-multistep-validation
Open

BUGFIX: validated step will not be validated again#66
MarcoPNS wants to merge 1 commit intoneos:mainfrom
MarcoPNS:bugfix-multistep-validation

Conversation

@MarcoPNS
Copy link
Copy Markdown

@MarcoPNS MarcoPNS commented Nov 3, 2021

Previously, an already validated step was not validated again when resending. This happens now.

Co-Authored-By: @arsors

Previously, an already validated step was not validated again when resending. This happens now.

Co-Authored-By: arsors <22658305+arsors@users.noreply.github.com>
@mficzel mficzel self-requested a review November 3, 2021 11:08
Copy link
Copy Markdown
Member

@mficzel mficzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pr, i understand the issue and agree that it should be solved.

However i somehow would prefer a solution that not specifically covers the __prev case
but also allows to render a navigation with multiple steps alla 1 - 2 - 3 ...

I suggest to use the name of the button that is clicked to separate between submits may cause a commit to the state and those that do not (steps backwards). Maybe __targetNoCommit alternatively to __target but i am not sure about the naming.

@mficzel
Copy link
Copy Markdown
Member

mficzel commented Dec 10, 2021

@MarcoPNS i build #72 upon your changes. Instead of a __prev key it uses an ! as prefix for the __target to identify the back navigation. I prefer this as this would work even when a custom form navigation with multiple keys is rendered.

Could you try this and give me feedback wether this works in your case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants