Update recipient and sender names to use empty string instead of null.#104
Merged
Update recipient and sender names to use empty string instead of null.#104
Conversation
Symfony Mailer expects the name to be a string and not null. Therefore setting the default of the names to an empty string will prevent us from throwing an exception if they are not set.
dlubitz
approved these changes
Feb 9, 2026
Contributor
dlubitz
left a comment
dlubitz
left a comment
There was a problem hiding this comment.
Looks good to me. Thank you @Benjamin-K
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symfony Mailer expects the name to be a string and not null (see Address implementation). Therefore setting the default of the names to an empty string will prevent us from throwing an exception if they are not set.
Resolves #98