-
Notifications
You must be signed in to change notification settings - Fork 4
NDEV-3552 cleanup old holder accounts #283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
artem-yazkov
wants to merge
7
commits into
develop
Choose a base branch
from
NDEV-3552-cleanup-holders
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afalaleev
reviewed
Mar 24, 2025
Member
afalaleev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Please fix 1 comment
proxy_client/common_holder.py
Outdated
| @classmethod | ||
| async def destroy_holder( | ||
| cls, | ||
| core_api_client: CoreApiClient, |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
core_api_client isn't used in the function.
Please remove it from the argument list.
Dapps report |
Solana Requests Statistics
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have two new commands in Proxy Client concerning legacy holder accounts
the command prints a list of all legacy holder accounts grouped by operator keys
the output format is the same as with holder list command, but
The command example
the command generates transactions to delete all existing holder accounts
after legacy holder accounts deletion is complete, the holder legacy-list command will return an empty legacy list
You can monitor the presence of legacy holder accounts before and after their deletion
Please note that SOLs on the balance of deleted accounts that have been moved to the operator account are the property of Neon.