NDEV-3839. Send update_account only for changed accounts #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ancientmage
force-pushed
the
NDEV-3839-update-only-changed-accounts
branch
from
3e8a562 to
226ee37
Compare
s-medvedev
reviewed
Oct 3, 2025
runtime/src/account_saver.rs
Outdated
| return false; | ||
| } | ||
|
|
||
| if account_is_executable { |
There was a problem hiding this comment.
Why the executable accounts are extracted to the separate case? As I understand they have account_owner which should match invoked_program_id as regular accounts.
ancientmage
force-pushed
the
NDEV-3839-update-only-changed-accounts
branch
from
226ee37 to
64a6d63
Compare
BoogVAr
pushed a commit
that referenced
this pull request
Nov 7, 2025
* Apply the retry code to the async pubsub client
Create a test server
```ts
import http from "http";
import { WebSocketServer } from "ws";
let attemptCount = 0;
const server = http.createServer();
const wss = new WebSocketServer({ noServer: true });
wss.on("connection", (ws) => {
ws.send("Connection accepted.");
ws.on("message", (msg) => console.log(`Received: ${msg}`));
});
server.on("upgrade", (req, socket, head) => {
attemptCount += 1;
if (attemptCount <= 4) {
socket.write("HTTP/1.1 429 Too Many Requests\r\n\r\n");
socket.destroy();
console.log(`Rejected connection #${attemptCount} (429)`);
return;
}
wss.handleUpgrade(req, socket, head, (ws) => {
wss.emit("connection", ws, req);
console.log("Connection accepted on attempt", attemptCount);
});
});
server.listen(8080, () => {
console.log("Server listening on port 8080");
});
```
Run `test_slot_subscription_async`:
```
Rejected connection #1 (429)
Rejected connection #2 (429)
Rejected connection #3 (429)
Rejected connection #4 (429)
Connection accepted on attempt 5
Received: {"id":1,"jsonrpc":"2.0","method":"slotSubscribe","params":[]}
```
* `s/async_with_retry/with_retry/`
…unt is writable in transaction
ancientmage
force-pushed
the
NDEV-3839-update-only-changed-accounts
branch
3 times, most recently
from
c6df636 to
59563b8
Compare
… might be changed by runtime
ancientmage
force-pushed
the
NDEV-3839-update-only-changed-accounts
branch
from
59563b8 to
d8045c1
Compare
s-medvedev
approved these changes
Nov 20, 2025
| account_owner: &Pubkey, | ||
| account_pubkey: &Pubkey, | ||
| ) -> bool { | ||
| let pubkey_str = account_pubkey.to_string(); |
There was a problem hiding this comment.
You can check that the owner is Sysvar1111111.....
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NDEV-3839. Send update_account only for changed accounts, even if the account is writable in the transaction