Conversation
whrvt
reviewed
Feb 10, 2026
|
|
||
| if !WASM_PLATFORM | ||
| BUILT_SOURCES += $(DEPS_CACHE)/curl-$(CURL_VERSION)/certbundle/cacert.pem | ||
| BUILT_SOURCES += $(DEPS_PREFIX)/ffmpeg-$(FFMPEG_VERSION).built |
| --enable-demuxer=mp3,aac,ogg,flac,wav,mov,m4a,matroska \ | ||
| --enable-decoder=mp3,aac,vorbis,opus,flac,pcm_s16le,pcm_f32le \ | ||
| --enable-parser=aac,flac,mpegaudio,vorbis,opus \ | ||
| --enable-avutil \ |
Collaborator
There was a problem hiding this comment.
why --disable- earlier then --enable- here
| --enable-avcodec \ | ||
| --enable-avformat \ | ||
| --enable-swresample \ | ||
| $(if $(WIN_PLATFORM),--target-os=mingw32,--target-os=$(if $(filter linux,$(SYSNAME)),linux,)) \ |
| --enable-avformat \ | ||
| --enable-swresample \ | ||
| $(if $(WIN_PLATFORM),--target-os=mingw32,--target-os=$(if $(filter linux,$(SYSNAME)),linux,)) \ | ||
| $(if $(filter x86_64,$(host_cpu)),--arch=x86_64,--arch=$(host_cpu)) && \ |
| $(MKDIR_P) $(DEPS_PREFIX)/ffmpeg/build $(DEPS_PREFIX)/lib/pkgconfig | ||
| $(TAR) xf $(DEPS_CACHE)/ffmpeg-$(FFMPEG_VERSION).tar.xz -C $(DEPS_PREFIX)/ffmpeg --strip-components=1 && \ | ||
| cd $(DEPS_PREFIX)/ffmpeg/build && \ | ||
| CC="$(CC)" CXX="$(CXX)" ../configure \ |
Collaborator
There was a problem hiding this comment.
may want --enable-gpl and --disable-nonfree
whrvt
reviewed
Feb 10, 2026
| $(MKDIR_P) $(DEPS_PREFIX)/ffmpeg/build $(DEPS_PREFIX)/lib/pkgconfig | ||
| $(TAR) xf $(DEPS_CACHE)/ffmpeg-$(FFMPEG_VERSION).tar.xz -C $(DEPS_PREFIX)/ffmpeg --strip-components=1 && \ | ||
| cd $(DEPS_PREFIX)/ffmpeg/build && \ | ||
| CC="$(CC)" CXX="$(CXX)" ../configure \ |
Collaborator
There was a problem hiding this comment.
also should do RANLIB="$(RANLIB)" AR="$(AR)" CC="$(CC)" CXX="$(CXX)" LD="$(LD)" CFLAGS="$(CFLAGS)" CXXFLAGS="$(CXXFLAGS)" LDFLAGS="$(LDFLAGS)" CPPFLAGS="$(CPPFLAGS)", instead of only CC/CXX, the flags aren't passed otherwise (see zlib build)
whrvt
reviewed
Feb 10, 2026
| --disable-muxers \ | ||
| --disable-hwaccels \ | ||
| --disable-protocols \ | ||
| --enable-protocol=file \ |
Collaborator
There was a problem hiding this comment.
i don't think we need that?
whrvt
reviewed
Feb 10, 2026
| --enable-protocol=file \ | ||
| --enable-demuxer=mp3,aac,ogg,flac,wav,mov,m4a,matroska \ | ||
| --enable-decoder=mp3,aac,vorbis,opus,flac,pcm_s16le,pcm_f32le \ | ||
| --enable-parser=aac,flac,mpegaudio,vorbis,opus \ |
Collaborator
There was a problem hiding this comment.
might want to also add mpeg4audio to these
also actually idk maybe they are parsers but not decoders? i just saw this in my logs by chance with the current ffmpeg builds (not from this branch):pcm_ things don't seem to exist (see ffmpeg configure)
[wav @ 0x7fff78053800] parser not found for codec pcm_s16le, packets or times may be invalid.
[wav @ 0x7fff78053800] Estimating duration from bitrate, this may be inaccurate
ffmpeg: seek skipped - already at frame 0
[pcm_s16le @ 0x7fff7802f980] Invalid PCM packet, data has size 2 but at least a size of 4 was expected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ci probably won't work first try, half vibe coded