Fix decimal hash to comply to hash contract #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukstei
commented
Dec 16, 2025
| let normalized = self.reduce(); | ||
| normalized.digits.hash(state); | ||
| normalized.cb.hash(state); | ||
| normalized.fractional_digits_count().hash(state); |
Author
There was a problem hiding this comment.
We need to include the fractional_digits_count, otherwise 10 and 100 would have the same hash after .reduce()
lukstei
commented
Dec 16, 2025
| (SIGNED, $dec: ident, $D: ident) => { | ||
| #[rstest(::trace)] | ||
| #[case($dec!(0.00), $dec!(-0.000))] | ||
| #[case($dec!(-0.00), $dec!(0.000))] |
Author
There was a problem hiding this comment.
these cases should have the same hash because they are also equal
Author
|
@neogenie Could you have a look please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the hash of
Decimalto not include the control block, see #59.