Skip to content

chore: bump MSRV to 1.88 and enable num-traits/libm #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
neogenie merged 2 commits into from
Dec 15, 2025
Merged

chore: bump MSRV to 1.88 and enable num-traits/libm #57

neogenie merged 2 commits into from
Dec 15, 2025

Conversation

@shuhuiluo
Copy link
Contributor

@shuhuiluo shuhuiluo commented Oct 31, 2025 •
edited
Loading

  • Bump Minimum Supported Rust Version from 1.87 to 1.88
  • Enable libm feature for num-traits in numtraits feature flag
  • Normalize code formatting and whitespace across codebase

@shuhuiluo shuhuiluo changed the title fix: enable libm for num-traits to resolve CI errors fix: enable libm for num-traits and pin home for MSRV 1.87 Oct 31, 2025
@shuhuiluo
Copy link
Contributor Author

shuhuiluo commented Nov 20, 2025

@neogenie Please merge this.

@neogenie
Copy link
Owner

neogenie commented Nov 23, 2025

Hi @shuhuiluo!

  1. I think we could just bump the version to MSRV 1.88.
  2. Shouldn't we add the dependency only for no_std?
  3. Pinning home crate looks like a duct tape.

@shuhuiluo shuhuiluo changed the title fix: enable libm for num-traits and pin home for MSRV 1.87 chore: bump MSRV to 1.88 and enable num-traits/libm Nov 23, 2025
@shuhuiluo
chore: bump MSRV to 1.88 and enable num-traits/libm
2488753 
- Bump Minimum Supported Rust Version from 1.87 to 1.88
- Enable libm feature for num-traits in numtraits feature flag
- Normalize code formatting and whitespace across codebase
@shuhuiluo
Copy link
Contributor Author

shuhuiluo commented Nov 24, 2025

Hi @shuhuiluo!

  1. I think we could just bump the version to MSRV 1.88.
  2. Shouldn't we add the dependency only for no_std?
  3. Pinning home crate looks like a duct tape.

@neogenie There is no no_std feature. Instead we should enable the dependencies' std feature for our std feature.

@shuhuiluo
Copy link
Contributor Author

shuhuiluo commented Dec 10, 2025

@neogenie What's is blocking a merge? A new release is necessary to fix the MSRV.

@neogenie neogenie merged commit 7bb68d5 into neogenie:master Dec 15, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shuhuiluo @neogenie