Skip to content

Project configuration improvements#60

Merged
darrenpicard25 merged 5 commits intomasterfrom
project-setup-changes
Feb 2, 2026
Merged

Project configuration improvements#60
darrenpicard25 merged 5 commits intomasterfrom
project-setup-changes

Conversation

@darrenpicard25
Copy link
Collaborator

@darrenpicard25 darrenpicard25 commented Jan 31, 2026

So this is breaking out alot of "project" improvements out of PR introducing plugin support. This PR

  • updates dependencies (all dev)
  • updated CI pipeline to perform matrix builds on multiple versions of node to ensure compatibility
  • added permission levels to CI
  • moved mongodb as dependency in chrono-mongo-datastore. We found many instances of npm/pnpm improperly resolving mongodb version if application had mongodb in dev-dependencies
  • Added startDate to processor COMPLETED event
  • set up pre-commit hook using lint-staged
  • vitest update required small change in base vitest config
  • added tsconfig files for test directory
  • set up stricter types with isolatedDeclarations in tsconfig
  • wrote some tests for processors

Only "publishable" change is the "mongodb" being moved to dependency. And cjs fixes in package.json

@wiz-a38520980d
Copy link

wiz-a38520980d bot commented Jan 31, 2026

Wiz Scan Summary

Scanner Findings
Vulnerability Finding Vulnerabilities -
Data Finding Sensitive Data -
Secret Finding Secrets -
IaC Misconfiguration IaC Misconfigurations -
SAST Finding SAST Findings -
Total -

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

/** The interval at which the processor will wait before next poll when an unexpected error occurs @default 20000ms */
processLoopRetryIntervalMs?: number;
};
export type ProcessorConfiguration = Partial<SimpleProcessorConfiguration> & { type?: 'simple' };
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i was redeclaring what was on SimpleProcessorConfiguration rather then just using the type

@darrenpicard25 darrenpicard25 marked this pull request as ready for review January 31, 2026 19:10
Copy link
Collaborator

@maiahneo maiahneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff here! Just one item below, not of a big deal but just want to surface the discussion.

Comment on lines +44 to +46
const _unreachable: never = processorType;

throw new Error(`Unknown processor type: ${processorType}`);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to declare _unreachable here? Can we just simply do like below?

Suggested change
const _unreachable: never = processorType;
throw new Error(`Unknown processor type: ${processorType}`);
throw new Error(`Unknown processor type: ${processorType}`);

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or I'm thinking instead of throwing we can just default to Simple processor if not provided?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can talk about this IRL. but essentially i update code to do "exhaustive" checks. So the only way this throw is possible is if someone force passes in a "type" that does not exist

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked IRL - tried it in my editor and it's awesome pattern 🤯

Comment on lines -32 to -33

ProcessorEvents.TASK_CLAIMED;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💣

Copy link
Collaborator

@maiahneo maiahneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪨

@darrenpicard25 darrenpicard25 merged commit 056b678 into master Feb 2, 2026
7 checks passed
@darrenpicard25 darrenpicard25 deleted the project-setup-changes branch February 2, 2026 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants