Use ExactSizeIterator for iterator-returning methods #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
This allowed me to remove this workaround: damyanp/corodaw@af9f549 |
damyanp
commented
Jan 31, 2026
| fn channels_iter(&self) -> impl Iterator<Item = impl Iterator<Item = &S> + '_> + '_ { | ||
| fn channels_iter( | ||
| &self, | ||
| ) -> impl '_ + ExactSizeIterator<Item = impl '_ + ExactSizeIterator<Item = &S>> |
Author
There was a problem hiding this comment.
If you think that this change is worth taking, I can go through and clean these up (these are artifacts from using clippy --fix).
Suggested change
| ) -> impl '_ + ExactSizeIterator<Item = impl '_ + ExactSizeIterator<Item = &S>> | |
| ) -> impl ExactSizeIterator<Item = impl ExactSizeIterator<Item = &S> + '_ > + '_ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some libraries (eg clack) require
ExactSizeIterators rather than plainIterators.This change makes all the methods that return
impl IteratorreturnExactSizeIteratorinstead to enable easier interop with these libraries.