Skip to content

bug: chunkedReader.Read read up to math.MaxInt on 32bit platforms #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nemith merged 1 commit into from
Jan 9, 2026
Merged

bug: chunkedReader.Read read up to math.MaxInt on 32bit platforms #137

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions transport/frame.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,12 @@ func (f *Framer) MsgWriter() (io.WriteCloser, error) {

var endOfChunks = []byte("\n##\n")

// maxChunkSize is the maximum chunk size for RFC 6242 chunked framing. RFC 6242
// allows up to MaxUint32 (4294967295), but on 32-bit systems slice lengths are
// limited to MaxInt (32-bit *signed*). We use the minimum of both to ensure
// compatibility across all architectures.
const maxChunkSize = min(math.MaxUint32, math.MaxInt)

// ErrMalformedChunk represents a message that invalid as defined in the chunk
// framing in RFC6242
var ErrMalformedChunk = errors.New("netconf: invalid chunk")
Expand Down Expand Up @@ -225,8 +231,8 @@ func (r *chunkedReader) Read(p []byte) (int, error) {
return 0, ErrInvalidIO
}

if len(p) > math.MaxUint32 {
p = p[:math.MaxUint32]
if len(p) > maxChunkSize {
p = p[:maxChunkSize]
}

// If we have no bytes left in the current chunk, we must read a new header
Expand Down Expand Up @@ -333,12 +339,6 @@ func (w *chunkedWriter) Write(p []byte) (int, error) {
return 0, ErrInvalidIO
}

// maxChunkSize is the maximum chunk size for RFC 6242 chunked framing.
// RFC 6242 allows up to MaxUint32 (4294967295), but on 32-bit systems
// slice lengths are limited to MaxInt32. We use the minimum of both
// to ensure compatibility across all architectures.
const maxChunkSize = min(math.MaxUint32, math.MaxInt)

totalWritten := 0
for len(p) > 0 {
chunkSize := min(len(p), maxChunkSize)
Expand Down