feat: add support for RFC5717 <partial-lock> #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This pull request adds support for RFC 5717 partial-lock operations, enabling fine-grained locking of specific datastore subtrees using XPath expressions. This complements the existing full datastore lock/unlock operations.
- Implements
PartialLockandPartialUnlockRPC operations with proper XML marshaling - Adds comprehensive unit tests for XML marshaling and execution of both operations
- Updates project documentation to reflect RFC 5717 support completion
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| rpc/config.go | Adds PartialLock, PartialLockReply, and PartialUnlock types with XML marshaling and Exec methods |
| rpc/config_test.go | Adds comprehensive unit tests for both marshal and exec operations of partial-lock and partial-unlock |
| README.md | Updates RFC support table to mark RFC 5717 as supported |
| TODO.md | Marks Partial Lock feature as completed in the future work list |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nemith
force-pushed
the
brb/push-wyxswsnmpkzs
branch
from
7622bfb to
186ab7b
Compare
nemith
force-pushed
the
brb/push-wyxswsnmpkzs
branch
from
186ab7b to
f14bb8a
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the RPC and to suppoirt RFC5717.