feat: adjust tall image split multiplier to 8#2932
Conversation
Adjusts how many times split tall images are split by increasing the hardcoded multiplier from 4 to 8, improving reader performance and optimizing splits based on the user's display maximum height. Co-authored-by: nonproto <2092019+nonproto@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
Code Review
This pull request improves code indentation in ApiMangaParser.kt and modifies the image splitting logic in ImageUtil.kt by increasing the optimal image height multiplier from 4 to 8. I have concerns regarding the change in ImageUtil.kt: increasing this multiplier results in larger image segments, which contradicts the goal of creating smaller pieces and risks exceeding hardware texture limits on many devices, potentially causing rendering failures. I recommend reconsidering this multiplier or decreasing it to improve performance and stability.
💡 What:
Increased the
optimalImageHeightcalculation multiplier from 4 to 8 inImageUtil.kt.🎯 Why:
The user requested to adjust how many times the split tall images get split, asking for the multiplier to be changed to 8. This improves the performance of the reader for extremely tall images by splitting them into relatively smaller pieces based on the user's screen dimensions.
PR created automatically by Jules for task 5250411805200091310 started by @nonproto