Skip to content

fix: allow cleartext to support user-hosted Suwayomi and Komga servers on local IP#2916

Merged
nonproto merged 3 commits intonekomangaorg:mainfrom
D-Brox:fix/httpLocal
Apr 11, 2026
Merged

fix: allow cleartext to support user-hosted Suwayomi and Komga servers on local IP#2916
nonproto merged 3 commits intonekomangaorg:mainfrom
D-Brox:fix/httpLocal

Conversation

@D-Brox
Copy link
Copy Markdown
Contributor

@D-Brox D-Brox commented Mar 31, 2026

Suwayomi and Komga support broke with #2869

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enables cleartext traffic to support user-hosted local servers like Suwayomi and Komga, while implementing security measures to prevent non-private HTTP connections. It introduces a CleartextPolicyInterceptor for OkHttp and a SecureWebViewClient for WebViews, both of which restrict HTTP requests to private IP ranges. The review feedback suggests handling potential UnknownHostException errors when resolving hostnames in SecureWebViewClient and expanding the private IP check to include IPv6 Unique Local Addresses (ULA).

Comment thread core/src/main/kotlin/tachiyomi/core/util/system/SecureWebViewClient.kt Outdated
@D-Brox
Copy link
Copy Markdown
Contributor Author

D-Brox commented Apr 10, 2026

This is for testing:

http://1.1.1.1

@D-Brox D-Brox marked this pull request as ready for review April 10, 2026 15:04
@nonproto nonproto merged commit 57f6146 into nekomangaorg:main Apr 11, 2026
2 checks passed
@D-Brox D-Brox deleted the fix/httpLocal branch April 12, 2026 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants