fix: allow cleartext to support user-hosted Suwayomi and Komga servers on local IP#2916
Merged
nonproto merged 3 commits intonekomangaorg:mainfrom Apr 11, 2026
Merged
fix: allow cleartext to support user-hosted Suwayomi and Komga servers on local IP#2916nonproto merged 3 commits intonekomangaorg:mainfrom
nonproto merged 3 commits intonekomangaorg:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request enables cleartext traffic to support user-hosted local servers like Suwayomi and Komga, while implementing security measures to prevent non-private HTTP connections. It introduces a CleartextPolicyInterceptor for OkHttp and a SecureWebViewClient for WebViews, both of which restrict HTTP requests to private IP ranges. The review feedback suggests handling potential UnknownHostException errors when resolving hostnames in SecureWebViewClient and expanding the private IP check to include IPv6 Unique Local Addresses (ULA).
Contributor
Author
|
This is for testing: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suwayomi and Komga support broke with #2869