Conversation
Adjusts the gem's dependency manifest, and makes adjustments to get the test suite to pass. Fixes #74
In 2-4-stable a code field was used for shipping methods. Here is the intention: > The expectation, like a sku, is that a shipping_method.code could represent an immutable value that is safe to bind against when figuring > out what shipping method to use. Fixes #78
Continuing the work from Follain, we update specs and tweak code where required to achieve 100% specs passing.
When importing images, I seem to get one of two different exceptions depending on... I'm not sure what. How the test is run? Anyway, it's better to be consistent so we re-raise one of the exceptions as the other at that point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know how active this repo is, but I wanted to offer my cleanup work to get this working with Solidus 2.2. I based my work off of https://github.com/Follain/solidus_cangaroo/tree/v2.2.1 which seemed like the most recent branch in this direction. All specs are green, and I get one remaining deprecation notice from somewhere within activesupport.
I did make a few changes that might not be the right thing to do:
skip_single_cart_validiationmethod (called from AddOrderHandler) so I removed it.If this work can be used by others, I'm happy to make changes to the PR. I'd hate for someone else to have to do the same stuff over again.