Skip to content

Conversation

@itechdima
Copy link
Collaborator

Problem

Right now logs granularity is not enough to distinguish different clusters. We need a separate attribute to be able to filter logs per cluster, since current cluster_name could be the same in different clusters.

Solution

Add attribute sp_resource_id to distinguish cluster related logs.

Testing

Release Notes

Feature: add sp_resource_id logs attribute and clusterId helm chart value for cluster log constraints.

@itechdima itechdima marked this pull request as ready for review January 14, 2026 15:52
@Uburro Uburro requested a review from Copilot January 14, 2026 16:22
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new clusterId configuration attribute to improve log filtering granularity across different clusters. The problem being solved is that the existing clusterName attribute can be the same across different clusters, making it difficult to distinguish logs from specific cluster instances.

Changes:

  • Added clusterId configuration field to helm chart values with an empty string default
  • Configured OpenTelemetry collectors to set sp_resource_id log attribute from the clusterId value when provided
  • Applied the change consistently across three OpenTelemetry collector configurations (logs, jail-logs, and events)

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
helm/soperator-fluxcd/values.yaml Adds new clusterId field to observability configuration with empty string default
helm/soperator-fluxcd/templates/opentelemetry-collector-logs.yaml Sets sp_resource_id attribute and CLUSTER_ID environment variable when clusterId is provided
helm/soperator-fluxcd/templates/opentelemetry-collector-jail-logs.yaml Sets sp_resource_id attribute and CLUSTER_ID environment variable when clusterId is provided
helm/soperator-fluxcd/templates/opentelemetry-collector-events.yaml Sets sp_resource_id attribute and CLUSTER_ID environment variable when clusterId is provided

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@itechdima itechdima merged commit df58b27 into main Jan 14, 2026
17 checks passed
@itechdima itechdima deleted the SCHED-696/add-more-attributes-for-logs branch January 14, 2026 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants