Include new checks for Grafana, Argo and Dask#563
Conversation
✅ Deploy Preview for nebari-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
After nebari-dev/nebari#2978 is merged this one can be as well |
| | deployment | verifies that a fresh deployment can run, deploy multiple pods, pass traffic, do a rolling update (without dropping connections), and clean up successfully | | ||
| | keycloak-http-check | verifies Keycloak is accessible | | ||
| | argo-http-check | verifies Argo Workflows Server is accessible | | ||
| | dask-gateway-http-check | verifies Dask Gateway Gateway API is running | |
There was a problem hiding this comment.
There's an extra "Gateway" in Dask Gateway
There was a problem hiding this comment.
well, that's the name of the check since its the name of the actual service listed in keycloak.I think its better to list the exact match since that's whats deployed, but if we just want to raise awareness I am fine with keeping the usual names
There was a problem hiding this comment.
Right, that's the name of the k8s service but I feel that's internal and users reading the documentation don't need to know the exact name but rather what "Nebari service" it refers to. That said, if you want to leave it like this, I don't have a problem with that.
| | keycloak-http-check | verifies Keycloak is accessible | | ||
| | argo-http-check | verifies Argo Workflows Server is accessible | | ||
| | dask-gateway-http-check | verifies Dask Gateway Gateway API is running | | ||
| | grafa-http-check | verifies Grafana is accessible | |
There was a problem hiding this comment.
The name is grafana-http-check
There was a problem hiding this comment.
ups, that's a typo thanks
There was a problem hiding this comment.
Can you push a fix with the correct name?
| | daemonset | verifies that a daemonset can be created, fully provisioned, and torn down. This checks the full kubelet functionality of every node in your Kubernetes cluster | | ||
| | deployment | verifies that a fresh deployment can run, deploy multiple pods, pass traffic, do a rolling update (without dropping connections), and clean up successfully | | ||
| | keycloak-http-check | verifies Keycloak is accessible | | ||
| | argo-http-check | verifies Argo Workflows Server is accessible | |
There was a problem hiding this comment.
I'd just keep Argo Workflows instead of Argo Workflows Server here but I'll leave that up to you
|
Hey @marcelovilla I left a few comments to your suggestions, can you have another look? |
marcelovilla
moved this from TODO 📬
to Changes requested 🧱
in 🪴 Nebari Project Management
✅ Deploy Preview for nebari-docs2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
2 participants
Reference Issues or PRs
What does this implement/fix?
Put a
xin the boxes that applyTesting
Documentation
Access-centered content checklist
Text styling
H1or#in markdown).Non-text content
Any other comments?