Skip to content
This repository was archived by the owner on Feb 25, 2026. It is now read-only.

Simon/documenting robust ecdsa folder#356

Merged
SimonRastikian merged 13 commits intomainfrom
simon/documenting-robust-ecdsa-folder
Feb 24, 2026
Merged

Simon/documenting robust ecdsa folder#356
SimonRastikian merged 13 commits intomainfrom
simon/documenting-robust-ecdsa-folder

Conversation

@SimonRastikian
Copy link
Contributor

@SimonRastikian SimonRastikian commented Feb 23, 2026

Documentation treating parts of #253 the ones related to CKD

@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.08%. Comparing base (4a47375) to head (1ddad1d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #356   +/-   ##
=======================================
  Coverage   88.08%   88.08%           
=======================================
  Files          57       57           
  Lines       10185    10185           
  Branches    10185    10185           
=======================================
  Hits         8971     8971           
  Misses        796      796           
  Partials      418      418           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gilcu3
Copy link
Contributor

gilcu3 commented Feb 23, 2026

Documentation treating parts of #253 the ones related to CKD

this PR does not seem related to CKD at all. Were you referring to something else?

Copy link
Contributor

@gilcu3 gilcu3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good, except the robust-ecdsa doc which seems inaccurate.
Afaik since #42 we have active security for robust-ecdsa, yet the doc mentions we are only secure for passive adversaries.

SimonRastikian and others added 7 commits February 23, 2026 23:04
Co-authored-by: Reynaldo Gil Pons <gilcu3@gmail.com>
Co-authored-by: Reynaldo Gil Pons <gilcu3@gmail.com>
Co-authored-by: Reynaldo Gil Pons <gilcu3@gmail.com>
Co-authored-by: Reynaldo Gil Pons <gilcu3@gmail.com>
Copy link
Contributor

@gilcu3 gilcu3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fixes

@SimonRastikian SimonRastikian self-assigned this Feb 23, 2026
Copy link

@DSharifi DSharifi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking time to document this!

It might make sense to incorporate these docs as rustdocs at some point if we want to publlish the crate for external users.

@SimonRastikian SimonRastikian merged commit 8d90dcb into main Feb 24, 2026
3 checks passed
@SimonRastikian SimonRastikian deleted the simon/documenting-robust-ecdsa-folder branch February 24, 2026 13:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants