Skip to content
This repository was archived by the owner on Oct 27, 2025. It is now read-only.

Make pre transfer deploys public#301

Open
esaminu wants to merge 7 commits intodevelopfrom
make-pre-transfer-deploys-public
Open

Make pre transfer deploys public#301
esaminu wants to merge 7 commits intodevelopfrom
make-pre-transfer-deploys-public

Conversation

@esaminu
Copy link
Contributor

@esaminu esaminu commented Apr 7, 2023

Make deploys module public until transfer for use with Near Discovery. The flow we have in mind is:

  1. Create github repo from near social component using template repo url on metadata on socialDB if existing or from scratch with single file + workflow
  2. Redirect to pagoda console with link to forked component deployed on testnet near social and created github repo etc
  3. When the user clicks "Transfer repo" in order to make changes, prompt to create pagoda console account or login

TODO

  • Make addConsoleDeployProject endpoint public
  • Make isRepositoryTransferred, listRepositories and listDeployments conditionally public
  • Require authentication when transferring the repo
  • Allow addConsoleDeployProject to take a socialDB path and create a repo with workflow from widget in that path

@esaminu esaminu requested a review from milenakrawczyk April 7, 2023 06:59
@vercel
Copy link

vercel bot commented Apr 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
developer-console-framework-prod ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 8, 2023 4:11am

Copy link
Contributor

@milenakrawczyk milenakrawczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution, @esaminu. Is it possible to test these changes?


@Post('addConsoleDeployProject')
@UseGuards(BearerAuthGuard)
// @UseGuards(BearerAuthGuard)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intentional that the guard is commented out?

projectSlug: repository.projectSlug,
};

return repository.projectSlug
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you share some details on a situation in which projectSlug is not defined? When does it happen?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants