Skip to content

Update localnet scripts to generate TOML config#2450

Open
barakeinav1 wants to merge 89 commits into2262-port-node-launcher-to-rust-v2from
update-localnet-scripts-to-toml
Open

Update localnet scripts to generate TOML config#2450
barakeinav1 wants to merge 89 commits into2262-port-node-launcher-to-rust-v2from
update-localnet-scripts-to-toml

Conversation

@barakeinav1
Copy link
Copy Markdown
Contributor

Summary

  • Replace flat key=value node config template with structured TOML template matching the new Rust tee-launcher Config struct
  • Update deploy-tee-localnet.sh and single-node.sh to render .toml configs with a ports_to_toml helper
  • Rename old template to .bak; update docs to reference node{i}.toml artifacts

Test plan

  • Run deploy-tee-localnet.sh with MODE=localnet N=2 and verify rendered .toml files are valid
  • Run single-node.sh and verify the launcher accepts the TOML config
  • Verify the generated TOML matches the structure in deployment/localnet/tee/sam.toml

🤖 Generated with Claude Code

DSharifi and others added 27 commits March 6, 2026 17:17
…es-and-cli-flags-from-mpc-binary' into 2262-port-node-launcher-to-rust-v2
The tee-launcher now expects a structured TOML config instead of flat
key=value env files. Update deploy-tee-localnet.sh and single-node.sh
to render TOML configs matching the new Config struct, and rename the
old template to .bak.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@claude
Copy link
Copy Markdown

claude bot commented Mar 15, 2026

PR title type suggestion: This PR updates localnet deployment scripts and configuration templates. Since these are development/infrastructure configuration changes rather than user-facing functionality, the type prefix should probably be chore: instead of feat:.

Suggested title: chore: update localnet scripts to generate TOML config

@claude
Copy link
Copy Markdown

claude bot commented Mar 15, 2026

Code Review: Update localnet scripts to generate TOML config

The new TOML template matches the Config struct in crates/tee-launcher/src/types.rs and aligns with the existing reference configs (deployment/localnet/tee/sam.toml, deployment/testnet/*.toml). The envsubst-based rendering approach is consistent with how the .env files are already generated.

No critical issues found.

Minor observations (non-blocking):

  • The ports_to_toml helper is duplicated verbatim across deploy-tee-localnet.sh and single-node.sh. If these scripts are expected to diverge this is fine; otherwise, extracting it to a shared sourced file would reduce maintenance burden. Not a blocker given these are deployment scripts.

  • The generated TOML will have a trailing comma after the last port entry (e.g., { src = 13002, dst = 13002 },). This is valid TOML per the spec (trailing commas in arrays are allowed), so no issue — just noting for awareness.

✅ Approved — straightforward migration from flat key=value config to structured TOML template that correctly matches the Rust Config struct.

@netrome netrome force-pushed the 2262-port-node-launcher-to-rust-v2 branch from 51b916c to f16a291 Compare March 23, 2026 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants