-
Notifications
You must be signed in to change notification settings - Fork 22
refactor: renaming Ed25519 to Edwards25519 #2409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SimonRastikian
wants to merge
27
commits into
main
Choose a base branch
from
simon/changing-ed25519-to-Curve25519
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
07d7c5f
Changing SignatureScheme into Curve
SimonRastikian 756501e
infer-purpose-from-curve
SimonRastikian 09204d8
Compatibility with serde
SimonRastikian 27ebb75
rename instead of alias for backwards compat
SimonRastikian 3f1fabe
Verifying alias still works
SimonRastikian 665dd0d
No changes on the contract interface after speaking to Kevin
SimonRastikian a1784ae
More revert
SimonRastikian 5ee59c6
Reverting all the SignatureScheme types in dto and interface
SimonRastikian cdfd46e
verify_foreign_tx__should_reject_non_foreign_tx_domain
SimonRastikian e255ece
No abi_has_not_changed file
SimonRastikian 5469dfb
Snap file changing
SimonRastikian f35b439
Merge branch 'main' into simon/SignatureScheme-Curve
SimonRastikian f324654
missing one curve
SimonRastikian dfb5674
Snap changes
SimonRastikian a99a445
Renaming ed25519 to Curve25519
SimonRastikian 0ac4bd6
Edwards25519
SimonRastikian b346820
Snap changed
SimonRastikian 20e149c
alias to rename
SimonRastikian 0d865c7
No more conflicts
SimonRastikian e52f8df
Missing one conflicted file
SimonRastikian e3e2430
Merge branch 'main' into simon/changing-ed25519-to-Curve25519
SimonRastikian d31df0c
Fixed: missing one Ed25519
SimonRastikian a452cea
Merge branch 'simon/changing-ed25519-to-Curve25519' of github.com:nea…
SimonRastikian e25ce47
update borsh
SimonRastikian b926872
borsh test
SimonRastikian eceb110
Merge branch 'main' into simon/changing-ed25519-to-Curve25519
SimonRastikian e2dacec
Merge branch 'main' into simon/changing-ed25519-to-Curve25519
SimonRastikian File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -301,8 +301,8 @@ BorshSchemaContainer { | |
| ), | ||
| ( | ||
| 1, | ||
| "Ed25519", | ||
| "Curve__Ed25519", | ||
| "Edwards25519", | ||
| "Curve__Edwards25519", | ||
| ), | ||
| ( | ||
| 2, | ||
|
|
@@ -319,7 +319,7 @@ BorshSchemaContainer { | |
| "Curve__Bls12381": Struct { | ||
| fields: Empty, | ||
| }, | ||
| "Curve__Ed25519": Struct { | ||
| "Curve__Edwards25519": Struct { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same question as above |
||
| fields: Empty, | ||
| }, | ||
| "Curve__Secp256k1": Struct { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this an external interface change?
what is the impact of it?