feat: create bounded vector for sign request args by DSharifi · Pull Request #2165 · near/mpc

DSharifi · 2026-02-18T18:55:30Z

DSharifi · 2026-02-20T09:52:27Z

crates/contract/src/primitives/signature.rs

-            schemars(with = "[u8; 32]"),
-            borsh(schema(with_funcs(
-                declaration = "<[u8; 32] as ::borsh::BorshSchema>::declaration",
-                definitions = "<[u8; 32] as ::borsh::BorshSchema>::add_definitions_recursively"
-            ),))
+            schemars(
+                with = "hex_serde::HexString<ECDSA_PAYLOAD_SIZE_BYTES, ECDSA_PAYLOAD_SIZE_BYTES>"
+            )
        )]
-        Bytes<32, 32>,
+        BoundedVec<u8, ECDSA_PAYLOAD_SIZE_BYTES, ECDSA_PAYLOAD_SIZE_BYTES>,
    ),
    Eddsa(
+        #[serde(with = "hex_serde")]
        #[cfg_attr(
            all(feature = "abi", not(target_arch = "wasm32")),
-            schemars(with = "Vec<u8>"),
-            borsh(schema(with_funcs(
-                declaration = "<Vec<u8> as ::borsh::BorshSchema>::declaration",
-                definitions = "<Vec<u8> as ::borsh::BorshSchema>::add_definitions_recursively"
-            ),))


There was previously a bug in the schema definition. We expect a hex string, but declared sequence of bytes (vector)

DSharifi · 2026-02-20T09:53:37Z

crates/contract/src/lib.rs

+#[derive(Debug, BorshSerialize, BorshDeserialize)]
+struct StaleData {
+    pending_signature_requests_pre_upgrade: LookupMap<v3_4_1_state::SignatureRequest, YieldIndex>,
+}
+
+impl StaleData {
+    fn new() -> Self {
+        Self {
+            pending_signature_requests_pre_upgrade: LookupMap::new(
+                StorageKey::PendingSignatureRequestsV2,
+            ),
+        }
+    }
+}


This migration step is needed because the new BoundedVec deosn't have idential borsh/hash implementation.

DSharifi · 2026-02-20T10:10:59Z

crates/bounded-collections/src/bounded_vec.rs

Most of the implementation is taken from https://github.com/ergoplatform/bounded-vec/blob/develop/src/bounded_vec.rs (license allows this).

Some small changes have been made, such as not implementing AsMut since that can break the invariants.

Borsh and scehma implementations have also been added for ABI generation.

DSharifi · 2026-02-20T10:13:25Z

crates/contract/tests/snapshots/abi__abi_has_not_changed.snap

@@ -2633,12 +2638,7 @@ expression: abi
              ],
              "properties": {
                "Eddsa": {
-                  "type": "array",
-                  "items": {
-                    "type": "integer",
-                    "format": "uint8",
-                    "minimum": 0.0
-                  }
+                  "$ref": "#/definitions/HexString_Min32_Max1232"
                }


There was previously a bug in the schema definition. We expect a hex string, but declared sequence of bytes (vector) in the schema

crates/contract/Cargo.toml

…sharifi/add-bounded-vec

claude · 2026-02-20T10:26:49Z

PR title type suggestion: This PR introduces a new bounded collections library with substantial new functionality (~2,000 lines of code in a new crate) integrated throughout the codebase for type-safe collection handling. The type prefix should probably be feat: instead of chore:

Suggested title: feat: create bounded collections for compile-time size validation

claude · 2026-02-20T10:27:09Z

PR title type suggestion: This PR introduces new crates and types (bounded-collections, non-empty-collections) with API changes and functional impact across the system, so the type prefix should probably be 'feat:' instead of 'chore:'.

Suggested title: 'feat: create bounded vector and non-empty collections for sign request args and foreign chains'

DSharifi · 2026-02-20T10:28:24Z

@claude please review

claude · 2026-02-20T10:28:45Z

PR Review: chore: create bounded vector for sign request args

I reviewed the full diff focusing on correctness, migration safety, and backward compatibility.

Summary

This PR replaces the ad-hoc Bytes<MIN_LEN, MAX_LEN> type with a general-purpose BoundedVec<T, L, U, W> for signature payloads, renames non-empty-collections to bounded-collections, and handles the on-chain state migration correctly by:

Moving old pending_signature_requests (V2 storage key) into StaleData during migration
Using a new V3 storage key for new requests
Adding fallback lookups/removals for in-flight pre-upgrade requests

Critical Issues Found

None. The migration strategy is sound:

Borsh compatibility: Both old Bytes(Vec<u8>) and new BoundedVec { inner: Vec<u8> } serialize identically via borsh (both delegate to Vec<u8>::serialize). Enum discriminants are preserved (same variant order).
Storage key separation: V2 key is preserved for stale data, V3 for new requests — no collision.
Fallback paths: get_pending_request, respond_signature, and return_signature_and_clean_state_on_success all correctly fall back to the pre-upgrade stale map.
Tests: New unit tests cover the stale-map fallback paths for timeout and success cases.

Minor Observations (non-blocking)

hex_serde::HexString::json_schema (bounded_vec.rs:799-800) uses (L * 2) as u32 and (U * 2) as u32 which could theoretically overflow for very large bounds. Not an issue with current usage (max 1232), but u32::try_from(L.checked_mul(2).unwrap_or(usize::MAX)) would be more defensive. This is ABI-only code so not a production concern.

✅ Approved — the migration is well-structured with proper fallback handling for in-flight requests.

gilcu3 · 2026-02-28T08:00:50Z

Superseded by #2199

DSharifi · 2026-03-01T13:38:54Z

Superseded by #2199

No, that PR did not close #2186

gilcu3 · 2026-03-01T13:45:03Z

Superseded by #2199

No, that PR did not close #2186

Then we should re-open #2186, it is closed now

DSharifi changed the title ~~chore: create bounded vector for transport types~~ chore: create bounded vector for sign request args Feb 19, 2026

.

7d172e1

DSharifi force-pushed the dsharifi/add-bounded-vec branch from dddaec2 to 7d172e1 Compare February 20, 2026 08:55

DSharifi and others added 4 commits February 20, 2026 10:17

revise on LLM reviews

02fcf18

create separate module for with hex

fdaa925

move bounds to conts

633b06e

Delete crates/near-mpc-sdk/src/sign.rs

9e78903

DSharifi commented Feb 20, 2026

View reviewed changes

Update crates/contract/Cargo.toml

338609a

DSharifi marked this pull request as ready for review February 20, 2026 10:24

DSharifi added 2 commits February 20, 2026 11:25

Merge remote-tracking branch 'origin/main' into dsharifi/add-bounded-vec

3d63bd0

Merge branch 'dsharifi/add-bounded-vec' of github.com:near/mpc into d…

d196924

…sharifi/add-bounded-vec

DSharifi changed the title ~~chore: create bounded vector for sign request args~~ feat: create bounded vector for sign request args Feb 20, 2026

DSharifi mentioned this pull request Feb 20, 2026

feat: add new collection type, BoundedVec, to the bounded collections crate #2199

Merged

gilcu3 closed this Feb 28, 2026

DSharifi reopened this Mar 1, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: create bounded vector for sign request args#2165

feat: create bounded vector for sign request args#2165
DSharifi wants to merge 8 commits intomainfrom
dsharifi/add-bounded-vec

DSharifi commented Feb 18, 2026 •

edited

Loading

Uh oh!

DSharifi Feb 20, 2026

Uh oh!

DSharifi Feb 20, 2026

Uh oh!

DSharifi Feb 20, 2026 •

edited

Loading

Uh oh!

DSharifi Feb 20, 2026

Uh oh!

Uh oh!

claude bot commented Feb 20, 2026

Uh oh!

claude bot commented Feb 20, 2026

Uh oh!

DSharifi commented Feb 20, 2026

Uh oh!

claude bot commented Feb 20, 2026

Uh oh!

gilcu3 commented Feb 28, 2026

Uh oh!

DSharifi commented Mar 1, 2026

Uh oh!

gilcu3 commented Mar 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

DSharifi commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DSharifi Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

DSharifi Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

DSharifi Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DSharifi Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

claude bot commented Feb 20, 2026

Uh oh!

claude bot commented Feb 20, 2026

Uh oh!

DSharifi commented Feb 20, 2026

Uh oh!

claude bot commented Feb 20, 2026

PR Review: chore: create bounded vector for sign request args

Summary

Critical Issues Found

Minor Observations (non-blocking)

Uh oh!

gilcu3 commented Feb 28, 2026

Uh oh!

DSharifi commented Mar 1, 2026

Uh oh!

gilcu3 commented Mar 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

DSharifi commented Feb 18, 2026 •

edited

Loading

DSharifi Feb 20, 2026 •

edited

Loading