Adapt to new simfil API#237
Merged
josephbirkner merged 5 commits intomapview-refactoringfrom Oct 20, 2025
Merged
Conversation
Release 2025.3.2
josephbirkner
approved these changes
Oct 20, 2025
| const result = uint8ArrayToWasm( | ||
| (wasmBuffer: any) => { | ||
| const featureLayerStyle = new coreLib.FeatureLayerStyle(wasmBuffer); | ||
| const featureLayerStyle = new coreLib.FeatureLayerStyle(wasmBuffer); // FIXME: No delete? Why create the object twice? |
Collaborator
There was a problem hiding this comment.
Yeah, we also caught this one in our refactoring 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates erdblick to use the changed simfil API from PR Klebert-Engineering/simfil#121
Using std::stringstream in a tight loop results in memory bugs under emscripten,
we already had a similar problem in simfil (internal std::locale calls keep allocating memory for some reason).
Ensure to always call
delete()on C++ objects. I've moved some calls intofinallyblocks.