Skip to content

Refactor #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ndm13 merged 29 commits into from
Dec 11, 2025
Merged

Refactor #22

ndm13 merged 29 commits into from
Dec 11, 2025

Conversation

@ndm13
Copy link
Owner

@ndm13 ndm13 commented Dec 11, 2025

Major structural changes:

  • Move to a handler-based model to centralize resources needed for each request type.
  • Middleware properly separated and imported.
  • Use lodash instead of reinventing the wheel.
  • Destructure global config and prefer argument passing.
  • Better consistency: imports, deno fmt.
  • Test suite to cover handler logic.
  • Better CI.

ndm13 added 27 commits December 7, 2025 23:00
@ndm13
Refactor to Handler classes
41a19b0 
- Should make future updates easier
- Increases readability, decreases compartmentalization
@ndm13
Cleanup and inline
b33963e
@ndm13
Fix miss in DemoHandler
07541d7
@ndm13
Export routes directly instead of using create functions
9f518b3
@ndm13
Consolidate utils and slipstream into context
ba8737a
@ndm13
Minor fixes
26e991a 
- Fix argument oversight in ProfileHandler
- Add type to import in server.ts
@ndm13
Remove redirectLink from context
34664db
@ndm13
Fix import without type in EmbedHandler
ab7acce
@ndm13
Begin destructuring config
bf0407f
@ndm13
Destructure config from AIDungeonAPI
790a6a2
@ndm13
Make config readonly
b02df37
@ndm13
Streamline metrics
b81ce2b 
- Pass metrics by value instead of using global
- Refactor `AIDungeonAPI` to use new Metrics class
- Make metrics entirely optional
@ndm13
Remove unnecessary await
7eeccb5
@ndm13
Split metrics into middleware and router
f78cee8
@ndm13
Make metrics argument optional
a3deb57
@ndm13
Introduce dedicated handler for oembed
b7fbbce
@ndm13
Split out logging and state middlewares
54bb18e
@ndm13
Use consistent pattern for middleware
000e31a
@ndm13
Fix oversight with metrics collector rename
8654d8f
@ndm13
Standardize import map namings
f5e366b
@ndm13
Tests
33b9dd1
@ndm13
Type check cleanup
7b93281
@ndm13
Type check cleanup (tests)
cb414ec
@ndm13
Update workflows
a834078 
- Added automated testing on pull request/push to main
- Pin update-deps.yml on Deno v2.x and suppress color codes in PR
@ndm13
deno fmt
03c5333
@ndm13
deno fmt (with exclude)
d05c106
@ndm13
Consistently format imports (opinionated)
9c2a471 
- Omit type so types and non-types can be bundled
- External dependencies, then internal dependencies, then globals
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 11, 2025
View reviewed changes
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 11, 2025
View reviewed changes
@ndm13 @github-advanced-security
Potential fix for code scanning alert no. 2: Workflow does not contai…
2b53b94 
…n permissions

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@ndm13
Add trailing slash to URL compare
8836288 
This will pass because the URL will have a path, but it's needed to keep Copilot from freaking out that there could be a suffix.
@ndm13 ndm13 merged commit 0c6e20c into main Dec 11, 2025
4 checks passed
@ndm13 ndm13 deleted the refactor branch December 11, 2025 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ndm13