-
Notifications
You must be signed in to change notification settings - Fork 20
Updates for Cullenect v2 #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This should probably be made cleverer, for now we rely on the need for this being known.
This was useful for debugging, but now we are also using a positional for the base type, this causes weird behaviour when passing --vscode and interleaving options with positionals.
Leaving this in here is harmless.
|
@CullenJWebb I think this is now matching your 2.0.3-beta geometry. The text emboss depth on top doesn't match (is 0.4mm instead of 0.2mm) but at the moment this is configured by argument directly (and not split per-base). I can make it change the text depth by default if you think it is important. Generating labels with this branch and the new shape: |
|
This looks excellent. I'm going to do some testing with this. |
|
What do you guys think about supporting changing x (and maybe y) dimensions for both version 1 and version 2 of cullenect ? The default size for version 1 is 36.4mm with a hole space of 36.7, however if you have a 1 unit length Gridfinity bin with the standard lip you only have 36.3 mm. Which sounds ok, but its too tight. Also someone might want a label for a less than ro greater than 1 unit bin. I would like to support changing the size of the label in the lip. For reference. |
|
It looks like the issue there is specifically that the gridfinity_extended_openscad changed geometry such that the standard labels don't fit any more? I'm open to adding the ability to tune the base sizes, as long as the "standard" size is the default. I think it'd be pretty simple to support changing the basic sizes with overrides. It would be easiest just to assume that the click-bars stay in the same relative size/position and the label ends up being whatever custom size on top of that. Does that sound like it would help? |
Support for Cullenect labels, in gridfinity extended was never finalised. I got it kind of working, but never really finalised it (the ticket is still open.
I think keeping the bars in the same position makes sense. Could we keep the pattern going, so after the first bar, a bar is every _n_mm following the current pattern? I also think that Cullenect labels would be useful for other projects that might want a smaller or larger label |
Like, span all the way to where the next bin would be? I've thought it would be useful to be able to have a multibin-length label, but was reluctant to invent my own modification of what was supposed to be a standard. Could always have it as advanced options, I guess. |
|
Okay, so it looks like the final v2 didn't have this orientation change at all, so I'll close this to separately add the real v2 update. |
see: #7
Incomplete list of changes/TODO:
webbbase tocullenect. "webb" is still accepted, but not shown in the base type list--versionfor specifying base model versions, defaulting tolatest. Currently only the Cullenect base has multiple versions, which arelatest,v1.1(same aslatest), andv2.0.3-beta. For now, exact version needs to be specified.