Skip to content

Conversation

@ndevenish
Copy link
Owner

@ndevenish ndevenish commented Dec 29, 2024

Currently following geometry as per download on https://makerworld.com/en/models/446624:

image

Edit: This is resolved

And not the geometry specified on https://github.com/CullenJWebb/Cullenect-Labels/blob/aab3dc1274e4addac05296cb42e7905df5af4c2d/README.md - there is an ambiguity on what size the label should be. The repo says

(42mm * Gridfinity_Units) - 6mm = 36 mm

But, the stl/Fusion 360 sources on Makerworld have the width as matching v1 of 36.4 mm. So, this is currently generating at 36.4 mm to match the actual download sources.

Not done: Variable label width, because I don't know how to calculate that (e.g. should it have the .4mm offset or not). It will be simple to add when I know the answer here :)

@ndevenish ndevenish linked an issue Dec 29, 2024 that may be closed by this pull request
@ndevenish
Copy link
Owner Author

As per #7 (comment), the documented widths are correct, so 42*u - 6 mm. I've added variable labels, and are double-checking the match with some test prints.

@Marus
Copy link

Marus commented Dec 30, 2024

I'd like to suggest two further additions to this is possible:

1 - Make it possible to supply the width both in MM and Gridfinity U's - while it is only occasion I do have some situations where I don't have a standard grid (either a partial unit at the end of a set that was sized using Gridfinity extended to fit a drawer that is not a multiple of 42mm or a non-standard grid-size).

2 - Ability to specify a height other than the standard 11mm (I've found with the bins generated I want my height to be 11.2 to get a snug fit)

@ndevenish
Copy link
Owner Author

1 - Make it possible to supply the width both in MM and Gridfinity U's - while it is only occasion I do have some situations where I don't have a standard grid (either a partial unit at the end of a set that was sized using Gridfinity extended to fit a drawer that is not a multiple of 42mm or a non-standard grid-size).

At the moment this is a bit awkwardly handled... some bases take u, some take mm. I could make the --width take units e.g. --width 32mm or --width 3 (or presumably --width 3u). I think this would work, but probably would want to change the other bases at the same time, so do after this.

2 - Ability to specify a height other than the standard 11mm (I've found with the bins generated I want my height to be 11.2 to get a snug fit)

There is a --height parameter already, but it is ignored for everything except plain and none bases. I think it'd be reasonable (and pretty simple) to allow this to override (if present) the heights of the other labels. I think I'd also rather merge this in then address that as a separate commit, because otherwise this PR ends up with a halfway-implemented mess.

@ndevenish
Copy link
Owner Author

I'll merge this now and address those separately, they are good ideas for making this useful

@ndevenish ndevenish merged commit dc7857d into main Dec 30, 2024
1 check passed
@ndevenish ndevenish deleted the cullenect_v2 branch December 30, 2024 18:11
@Marus
Copy link

Marus commented Dec 31, 2024

Yeah - that makes sense if you want to extend that functionality to the other base types (which again probably does make sense). Thanks for the great work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cullenect Labels V2 Implementation

3 participants