Open
Conversation
this fixes the simple bug on `if` the condition of the `alias_update_urltables` function.
Author
|
@ndejong please review this |
|
Be great to get this reviewed - as the current version alias_update_urltables is completely broken. Oddly, the package as is available to download currently actually as singular "alias" in the line below (like a fix was attempted but the wrong line updated) I applied this fix directly and it works a treat. Guess it's a pfsense 2.5 change? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this fixes the simple bug on the
ifcondition in thealias_update_urltablesfunction.