refactor: replace httr and xml2 dependencies from SDA_query with base R/curl #433
+69
−117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brownag
force-pushed
the
lowdep-sdaquery
branch
from
496a568 to
d9dbfc2
Compare
- the "daily maintenance" response is not a standard JSON/XML service exception, just an HTML page
brownag
changed the title
brownag
force-pushed
the
lowdep-sdaquery
branch
from
26ab16f to
2949692
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For soilDB 2.9.x milestone, to be merged into #426 if testing succeeds.
Draft PR to remove dependency on httr and xml2 within SDA_query. httr is basically just syntactic sugar around curl, and xml2 is only needed for parsing
ServiceExceptions when errors occur. jsonlite (or perhaps yyjsonr replacement) can be moved to imports. That way any installation of soilDB with imports only can run SDA_query without installing any additional packages., or replace with yyjsonr