test: cover additional root error branches

Author: ncode

cmd/root.go

@@ -34,6 +34,12 @@ var cfgFile string
 var hostsFile string
 var hostGroup string
 
+var loadSSHConfigFunc = sshConn.LoadSSHConfig
+
+var resolveHostFunc = func(resolver *sshConn.SSHConfigResolver, spec sshConn.HostSpec, fallbackUser string) (sshConn.ResolvedHost, error) {
+	return resolver.ResolveHost(spec, fallbackUser)
+}
+
 // RootCmd represents the base command when called without any subcommands
 var RootCmd = &cobra.Command{
 	Use:   "pretty",
@@ -106,7 +112,7 @@ usage:
 		if home, err := os.UserHomeDir(); err == nil {
 			userConfigPath = filepath.Join(home, ".ssh", "config")
 		}
-		resolver, err := sshConn.LoadSSHConfig(sshConn.SSHConfigPaths{
+		resolver, err := loadSSHConfigFunc(sshConn.SSHConfigPaths{
 			User:   userConfigPath,
 			System: "/etc/ssh/ssh_config",
 		})
@@ -130,7 +136,7 @@ usage:
 				resolveSpec.User = globalUser
 				resolveSpec.UserSet = true
 			}
-			resolved, err := resolver.ResolveHost(resolveSpec, "")
+			resolved, err := resolveHostFunc(resolver, resolveSpec, "")
 			if err != nil {
 				return fmt.Errorf("unable to resolve host %q: %w", spec.Host, err)
 			}
@@ -141,7 +147,7 @@ usage:
 					jumpSpec.User = globalUser
 					jumpSpec.UserSet = true
 				}
-				jumpResolved, err := resolver.ResolveHost(jumpSpec, "")
+				jumpResolved, err := resolveHostFunc(resolver, jumpSpec, "")
 				if err != nil {
 					return fmt.Errorf("unable to resolve jump host %q: %w", jumpAlias, err)
 				}

cmd/root_test.go

@@ -1,9 +1,12 @@
 package cmd
 
 import (
+	"errors"
+	"os"
 	"strings"
 	"testing"
 
+	"github.com/ncode/pretty/internal/sshConn"
 	"github.com/spf13/viper"
 )
 
@@ -102,3 +105,135 @@ func TestExecuteReturnsErrorForInvalidGroupSpec(t *testing.T) {
 		t.Fatalf("unexpected error: %v", err)
 	}
 }
+
+func TestExecuteReturnsErrorForInvalidHostsFileContent(t *testing.T) {
+	prevHostGroup := hostGroup
+	prevHostsFile := hostsFile
+	t.Cleanup(func() {
+		hostGroup = prevHostGroup
+		hostsFile = prevHostsFile
+		RootCmd.SetArgs(nil)
+	})
+
+	f, err := os.CreateTemp(t.TempDir(), "hosts-*.txt")
+	if err != nil {
+		t.Fatalf("unexpected temp file error: %v", err)
+	}
+	if _, err := f.WriteString("host1:badport\n"); err != nil {
+		t.Fatalf("unexpected write error: %v", err)
+	}
+	if err := f.Close(); err != nil {
+		t.Fatalf("unexpected close error: %v", err)
+	}
+
+	hostGroup = ""
+	hostsFile = f.Name()
+	RootCmd.SetArgs([]string{"host2"})
+
+	err = Execute()
+	if err == nil {
+		t.Fatalf("expected error")
+	}
+	if !strings.Contains(err.Error(), "invalid port") {
+		t.Fatalf("unexpected error: %v", err)
+	}
+}
+
+func TestExecuteReturnsErrorWhenLoadingSSHConfigFails(t *testing.T) {
+	prevHostGroup := hostGroup
+	prevHostsFile := hostsFile
+	prevLoad := loadSSHConfigFunc
+	t.Cleanup(func() {
+		hostGroup = prevHostGroup
+		hostsFile = prevHostsFile
+		loadSSHConfigFunc = prevLoad
+		RootCmd.SetArgs(nil)
+	})
+
+	loadSSHConfigFunc = func(paths sshConn.SSHConfigPaths) (*sshConn.SSHConfigResolver, error) {
+		return nil, errors.New("config boom")
+	}
+
+	hostGroup = ""
+	hostsFile = ""
+	RootCmd.SetArgs([]string{"host1"})
+
+	err := Execute()
+	if err == nil {
+		t.Fatalf("expected error")
+	}
+	if !strings.Contains(err.Error(), "unable to load ssh config") {
+		t.Fatalf("unexpected error: %v", err)
+	}
+}
+
+func TestExecuteReturnsErrorWhenResolveHostFails(t *testing.T) {
+	prevHostGroup := hostGroup
+	prevHostsFile := hostsFile
+	prevLoad := loadSSHConfigFunc
+	prevResolve := resolveHostFunc
+	t.Cleanup(func() {
+		hostGroup = prevHostGroup
+		hostsFile = prevHostsFile
+		loadSSHConfigFunc = prevLoad
+		resolveHostFunc = prevResolve
+		RootCmd.SetArgs(nil)
+	})
+
+	loadSSHConfigFunc = func(paths sshConn.SSHConfigPaths) (*sshConn.SSHConfigResolver, error) {
+		return &sshConn.SSHConfigResolver{}, nil
+	}
+	resolveHostFunc = func(resolver *sshConn.SSHConfigResolver, spec sshConn.HostSpec, fallbackUser string) (sshConn.ResolvedHost, error) {
+		return sshConn.ResolvedHost{}, errors.New("resolve boom")
+	}
+
+	hostGroup = ""
+	hostsFile = ""
+	RootCmd.SetArgs([]string{"host1"})
+
+	err := Execute()
+	if err == nil {
+		t.Fatalf("expected error")
+	}
+	if !strings.Contains(err.Error(), "unable to resolve host") {
+		t.Fatalf("unexpected error: %v", err)
+	}
+}
+
+func TestExecuteReturnsErrorWhenResolveJumpFails(t *testing.T) {
+	prevHostGroup := hostGroup
+	prevHostsFile := hostsFile
+	prevLoad := loadSSHConfigFunc
+	prevResolve := resolveHostFunc
+	t.Cleanup(func() {
+		hostGroup = prevHostGroup
+		hostsFile = prevHostsFile
+		loadSSHConfigFunc = prevLoad
+		resolveHostFunc = prevResolve
+		RootCmd.SetArgs(nil)
+	})
+
+	loadSSHConfigFunc = func(paths sshConn.SSHConfigPaths) (*sshConn.SSHConfigResolver, error) {
+		return &sshConn.SSHConfigResolver{}, nil
+	}
+	call := 0
+	resolveHostFunc = func(resolver *sshConn.SSHConfigResolver, spec sshConn.HostSpec, fallbackUser string) (sshConn.ResolvedHost, error) {
+		call++
+		if call == 1 {
+			return sshConn.ResolvedHost{Alias: spec.Alias, Host: spec.Host, Port: 22, ProxyJump: []string{"jump1"}}, nil
+		}
+		return sshConn.ResolvedHost{}, errors.New("jump boom")
+	}
+
+	hostGroup = ""
+	hostsFile = ""
+	RootCmd.SetArgs([]string{"host1"})
+
+	err := Execute()
+	if err == nil {
+		t.Fatalf("expected error")
+	}
+	if !strings.Contains(err.Error(), "unable to resolve jump host") {
+		t.Fatalf("unexpected error: %v", err)
+	}
+}