test: cover root and main error paths

Author: ncode

cmd/root_test.go

@@ -3,6 +3,8 @@ package cmd
 import (
 	"strings"
 	"testing"
+
+	"github.com/spf13/viper"
 )
 
 func TestRootCmdUsesRunE(t *testing.T) {
@@ -32,3 +34,71 @@ func TestExecuteReturnsErrorForMissingHosts(t *testing.T) {
 		t.Fatalf("unexpected error: %v", err)
 	}
 }
+
+func TestExecuteReturnsErrorForInvalidHostSpec(t *testing.T) {
+	prevHostGroup := hostGroup
+	prevHostsFile := hostsFile
+	t.Cleanup(func() {
+		hostGroup = prevHostGroup
+		hostsFile = prevHostsFile
+		RootCmd.SetArgs(nil)
+	})
+
+	hostGroup = ""
+	hostsFile = ""
+	RootCmd.SetArgs([]string{":"})
+
+	err := Execute()
+	if err == nil {
+		t.Fatalf("expected error")
+	}
+	if !strings.Contains(err.Error(), "invalid host") {
+		t.Fatalf("unexpected error: %v", err)
+	}
+}
+
+func TestExecuteReturnsErrorWhenHostsFileCannotBeRead(t *testing.T) {
+	prevHostGroup := hostGroup
+	prevHostsFile := hostsFile
+	t.Cleanup(func() {
+		hostGroup = prevHostGroup
+		hostsFile = prevHostsFile
+		RootCmd.SetArgs(nil)
+	})
+
+	hostGroup = ""
+	hostsFile = "/path/that/does/not/exist"
+	RootCmd.SetArgs([]string{"host1"})
+
+	err := Execute()
+	if err == nil {
+		t.Fatalf("expected error")
+	}
+	if !strings.Contains(err.Error(), "unable to read hostsFile") {
+		t.Fatalf("unexpected error: %v", err)
+	}
+}
+
+func TestExecuteReturnsErrorForInvalidGroupSpec(t *testing.T) {
+	prevHostGroup := hostGroup
+	prevHostsFile := hostsFile
+	t.Cleanup(func() {
+		hostGroup = prevHostGroup
+		hostsFile = prevHostsFile
+		viper.Set("groups.bad", nil)
+		RootCmd.SetArgs(nil)
+	})
+
+	viper.Set("groups.bad", map[string]interface{}{"user": "deploy"})
+	hostGroup = "bad"
+	hostsFile = ""
+	RootCmd.SetArgs([]string{"host1"})
+
+	err := Execute()
+	if err == nil {
+		t.Fatalf("expected error")
+	}
+	if !strings.Contains(err.Error(), "missing hosts") {
+		t.Fatalf("unexpected error: %v", err)
+	}
+}

main_test.go

@@ -0,0 +1,32 @@
+package main
+
+import (
+	"errors"
+	"os"
+	"os/exec"
+	"strings"
+	"testing"
+)
+
+func TestMainExitsOnExecuteError(t *testing.T) {
+	if os.Getenv("PRETTY_MAIN_CHILD") == "1" {
+		os.Args = []string{"pretty"}
+		main()
+		return
+	}
+
+	cmd := exec.Command(os.Args[0], "-test.run=TestMainExitsOnExecuteError")
+	cmd.Env = append(os.Environ(), "PRETTY_MAIN_CHILD=1")
+	out, err := cmd.CombinedOutput()
+
+	var exitErr *exec.ExitError
+	if !errors.As(err, &exitErr) {
+		t.Fatalf("expected process exit error, got %v", err)
+	}
+	if exitErr.ExitCode() != 1 {
+		t.Fatalf("expected exit code 1, got %d", exitErr.ExitCode())
+	}
+	if !strings.Contains(string(out), "requires at least one host") {
+		t.Fatalf("expected error output, got %q", string(out))
+	}
+}